Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[PATCH] arm: add comment about dma_supported()

)


From: Russell King <rmk+lkml@arm.linux.org.uk>

The ARM dma_supported() is rather basic, and I don't think it takes into
account everything that it should do (eg, whether the mask agrees with what
we'd return for GFP_DMA allocations). Note this.

Signed-off-by: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

authored by

akpm@osdl.org and committed by
Linus Torvalds
7a228aaa 7aa52f51

+3
+3
include/asm-arm/dma-mapping.h
··· 21 21 * properly. For example, if your device can only drive the low 24-bits 22 22 * during bus mastering, then you would pass 0x00ffffff as the mask 23 23 * to this function. 24 + * 25 + * FIXME: This should really be a platform specific issue - we should 26 + * return false if GFP_DMA allocations may not satisfy the supplied 'mask'. 24 27 */ 25 28 static inline int dma_supported(struct device *dev, u64 mask) 26 29 {