Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

USB: serial: use tty_port_register_device()

We already have the tty port when probing a usb-serial port so use
tty_port_register_device() directly instead of tty_port_install() later
to set up the port link.

This is a step towards enabling serdev for usb-serial (but we need to
determine how to handle hotplugging first).

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>

+3 -2
+2 -1
drivers/usb/serial/bus.c
··· 60 60 } 61 61 62 62 minor = port->minor; 63 - tty_dev = tty_register_device(usb_serial_tty_driver, minor, dev); 63 + tty_dev = tty_port_register_device(&port->port, usb_serial_tty_driver, 64 + minor, dev); 64 65 if (IS_ERR(tty_dev)) { 65 66 retval = PTR_ERR(tty_dev); 66 67 goto err_port_remove;
+1 -1
drivers/usb/serial/usb-serial.c
··· 192 192 if (retval) 193 193 goto error_get_interface; 194 194 195 - retval = tty_port_install(&port->port, driver, tty); 195 + retval = tty_standard_install(driver, tty); 196 196 if (retval) 197 197 goto error_init_termios; 198 198