Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm: Remove unused MIPI write seq and chatty functions

Remove the deprecated mipi_dsi_generic_write_seq() and
mipi_dsi_generic_write_chatty() functions now that they are no longer
used.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Brigham Campbell <me@brighamcampbell.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20250722015313.561966-4-me@brighamcampbell.com

authored by

Brigham Campbell and committed by
Douglas Anderson
79b6bb18 a6adf47d

+3 -54
+3 -31
drivers/gpu/drm/drm_mipi_dsi.c
··· 772 772 EXPORT_SYMBOL(mipi_dsi_generic_write); 773 773 774 774 /** 775 - * mipi_dsi_generic_write_chatty() - mipi_dsi_generic_write() w/ an error log 776 - * @dsi: DSI peripheral device 777 - * @payload: buffer containing the payload 778 - * @size: size of payload buffer 779 - * 780 - * Like mipi_dsi_generic_write() but includes a dev_err() 781 - * call for you and returns 0 upon success, not the number of bytes sent. 782 - * 783 - * Return: 0 on success or a negative error code on failure. 784 - */ 785 - int mipi_dsi_generic_write_chatty(struct mipi_dsi_device *dsi, 786 - const void *payload, size_t size) 787 - { 788 - struct device *dev = &dsi->dev; 789 - ssize_t ret; 790 - 791 - ret = mipi_dsi_generic_write(dsi, payload, size); 792 - if (ret < 0) { 793 - dev_err(dev, "sending generic data %*ph failed: %zd\n", 794 - (int)size, payload, ret); 795 - return ret; 796 - } 797 - 798 - return 0; 799 - } 800 - EXPORT_SYMBOL(mipi_dsi_generic_write_chatty); 801 - 802 - /** 803 - * mipi_dsi_generic_write_multi() - mipi_dsi_generic_write_chatty() w/ accum_err 775 + * mipi_dsi_generic_write_multi() - mipi_dsi_generic_write() w/ accum_err 804 776 * @ctx: Context for multiple DSI transactions 805 777 * @payload: buffer containing the payload 806 778 * @size: size of payload buffer 807 779 * 808 - * Like mipi_dsi_generic_write_chatty() but deals with errors in a way that 809 - * makes it convenient to make several calls in a row. 780 + * A wrapper around mipi_dsi_generic_write() that deals with errors in a way 781 + * that makes it convenient to make several calls in a row. 810 782 */ 811 783 void mipi_dsi_generic_write_multi(struct mipi_dsi_multi_context *ctx, 812 784 const void *payload, size_t size)
-23
include/drm/drm_mipi_dsi.h
··· 285 285 286 286 ssize_t mipi_dsi_generic_write(struct mipi_dsi_device *dsi, const void *payload, 287 287 size_t size); 288 - int mipi_dsi_generic_write_chatty(struct mipi_dsi_device *dsi, 289 - const void *payload, size_t size); 290 288 void mipi_dsi_generic_write_multi(struct mipi_dsi_multi_context *ctx, 291 289 const void *payload, size_t size); 292 290 void mipi_dsi_dual_generic_write_multi(struct mipi_dsi_multi_context *ctx, ··· 384 386 void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx, 385 387 u16 scanline); 386 388 void mipi_dsi_dcs_set_tear_off_multi(struct mipi_dsi_multi_context *ctx); 387 - 388 - /** 389 - * mipi_dsi_generic_write_seq - transmit data using a generic write packet 390 - * 391 - * This macro will print errors for you and will RETURN FROM THE CALLING 392 - * FUNCTION (yes this is non-intuitive) upon error. 393 - * 394 - * Because of the non-intuitive return behavior, THIS MACRO IS DEPRECATED. 395 - * Please replace calls of it with mipi_dsi_generic_write_seq_multi(). 396 - * 397 - * @dsi: DSI peripheral device 398 - * @seq: buffer containing the payload 399 - */ 400 - #define mipi_dsi_generic_write_seq(dsi, seq...) \ 401 - do { \ 402 - static const u8 d[] = { seq }; \ 403 - int ret; \ 404 - ret = mipi_dsi_generic_write_chatty(dsi, d, ARRAY_SIZE(d)); \ 405 - if (ret < 0) \ 406 - return ret; \ 407 - } while (0) 408 389 409 390 /** 410 391 * mipi_dsi_generic_write_seq_multi - transmit data using a generic write packet