Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

backlight: da9052_bl: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Adam Ward <DLG-Adam.Ward.opensource@dm.renesas.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230308073945.2336302-5-u.kleine-koenig@pengutronix.de

authored by

Uwe Kleine-König and committed by
Lee Jones
78a2bb48 f6672d7f

+2 -4
+2 -4
drivers/video/backlight/da9052_bl.c
··· 135 135 return da9052_adjust_wled_brightness(wleds); 136 136 } 137 137 138 - static int da9052_backlight_remove(struct platform_device *pdev) 138 + static void da9052_backlight_remove(struct platform_device *pdev) 139 139 { 140 140 struct backlight_device *bl = platform_get_drvdata(pdev); 141 141 struct da9052_bl *wleds = bl_get_data(bl); ··· 143 143 wleds->brightness = 0; 144 144 wleds->state = DA9052_WLEDS_OFF; 145 145 da9052_adjust_wled_brightness(wleds); 146 - 147 - return 0; 148 146 } 149 147 150 148 static const struct platform_device_id da9052_wled_ids[] = { ··· 164 166 165 167 static struct platform_driver da9052_wled_driver = { 166 168 .probe = da9052_backlight_probe, 167 - .remove = da9052_backlight_remove, 169 + .remove_new = da9052_backlight_remove, 168 170 .id_table = da9052_wled_ids, 169 171 .driver = { 170 172 .name = "da9052-wled",