Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

um: fix default console kernel parameter

OpenWrt's UML with 5.15 was producing odd errors/warnings during preinit
part of the early userspace portion:

|[ 0.000000] Kernel command line: ubd0=root.img root=98:0 console=tty
|[...]
|[ 0.440000] random: jshn: uninitialized urandom read (4 bytes read)
|[ 0.460000] random: jshn: uninitialized urandom read (4 bytes read)
|/etc/preinit: line 47: can't create /dev/tty: No such device or address
|/etc/preinit: line 48: can't create /dev/tty: No such device or address
|/etc/preinit: line 58: can't open /dev/tty: No such device or address
|[...] repeated many times

That "/dev/tty" came from the command line (which is automatically
added if no console= parameter was specified for the uml binary).

The TLDP project tells the following about the /dev/tty:
<https://tldp.org/HOWTO/Text-Terminal-HOWTO-7.html#ss7.3>
| /dev/tty stands for the controlling terminal (if any) for the current
| process.[...]
| /dev/tty is something like a link to the actually terminal device[..]

The "(if any)" is important here, since it's possible for processes to
not have a controlling terminal.

I think this was a simple typo and the author wanted tty0 there.

CC: Thomas Meyer <thomas@m3y3r.de>
Fixes: d7ffac33631b ("um: stdio_console: Make preferred console")
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>

authored by

Christian Lamparter and committed by
Richard Weinberger
782b1f70 d27fff34

+1 -1
+1 -1
arch/um/kernel/um_arch.c
··· 33 33 #include "um_arch.h" 34 34 35 35 #define DEFAULT_COMMAND_LINE_ROOT "root=98:0" 36 - #define DEFAULT_COMMAND_LINE_CONSOLE "console=tty" 36 + #define DEFAULT_COMMAND_LINE_CONSOLE "console=tty0" 37 37 38 38 /* Changed in add_arg and setup_arch, which run before SMP is started */ 39 39 static char __initdata command_line[COMMAND_LINE_SIZE] = { 0 };