Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

power: supply: lp8788-charger: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230918133700.1254499-17-u.kleine-koenig@pengutronix.de
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

authored by

Uwe Kleine-König and committed by
Sebastian Reichel
7810ba3c cf79047e

+2 -4
+2 -4
drivers/power/supply/lp8788-charger.c
··· 714 714 return 0; 715 715 } 716 716 717 - static int lp8788_charger_remove(struct platform_device *pdev) 717 + static void lp8788_charger_remove(struct platform_device *pdev) 718 718 { 719 719 struct lp8788_charger *pchg = platform_get_drvdata(pdev); 720 720 721 721 flush_work(&pchg->charger_work); 722 722 lp8788_irq_unregister(pdev, pchg); 723 723 lp8788_psy_unregister(pchg); 724 - 725 - return 0; 726 724 } 727 725 728 726 static struct platform_driver lp8788_charger_driver = { 729 727 .probe = lp8788_charger_probe, 730 - .remove = lp8788_charger_remove, 728 + .remove_new = lp8788_charger_remove, 731 729 .driver = { 732 730 .name = LP8788_DEV_CHARGER, 733 731 },