Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rds: Fix endianness annotation for RDS_MPATH_HASH

jhash_1word accepts host endian inputs while rs_bound_port is a be16
value (sockaddr_in6.sin6_port). Use ntohs() for consistency.

Flagged by Sparse.

Signed-off-by: Ujwal Kundur <ujwal.kundur@gmail.com>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Link: https://patch.msgid.link/20250820175550.498-4-ujwal.kundur@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Ujwal Kundur and committed by
Jakub Kicinski
77907a06 92b92529

+1 -1
+1 -1
net/rds/rds.h
··· 93 93 94 94 /* Max number of multipaths per RDS connection. Must be a power of 2 */ 95 95 #define RDS_MPATH_WORKERS 8 96 - #define RDS_MPATH_HASH(rs, n) (jhash_1word((rs)->rs_bound_port, \ 96 + #define RDS_MPATH_HASH(rs, n) (jhash_1word(ntohs((rs)->rs_bound_port), \ 97 97 (rs)->rs_hash_initval) & ((n) - 1)) 98 98 99 99 #define IS_CANONICAL(laddr, faddr) (htonl(laddr) < htonl(faddr))