Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

xen/pvcalls: remove redundant check for irq >= 0

This is a moot point, but irq is always less than zero at the label
out_error, so the check for irq >= 0 is redundant and can be removed.

Detected by CoverityScan, CID#1460371 ("Logically dead code")

Fixes: cb1c7d9bbc87 ("xen/pvcalls: implement connect command")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

authored by

Colin Ian King and committed by
Boris Ostrovsky
773aaadc 95110ac8

+1 -3
+1 -3
drivers/xen/pvcalls-front.c
··· 351 351 return 0; 352 352 353 353 out_error: 354 - if (irq >= 0) 355 - unbind_from_irqhandler(irq, map); 356 - else if (*evtchn >= 0) 354 + if (*evtchn >= 0) 357 355 xenbus_free_evtchn(pvcalls_front_dev, *evtchn); 358 356 kfree(map->active.data.in); 359 357 kfree(map->active.ring);