Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

soundwire: debugfs: use controller id and link_id for debugfs

link_id can be zero and if we have multiple controller instances
in a system like Qualcomm debugfs will end-up with duplicate namespace
resulting in incorrect debugfs entries.

Using bus-id and link-id combination should give a unique debugfs directory
entry and should fix below warning too.
"debugfs: Directory 'master-0' with parent 'soundwire' already present!"

Fixes: bf03473d5bcc ("soundwire: add debugfs support")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210907105332.1257-1-srinivas.kandagatla@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Srinivas Kandagatla and committed by
Vinod Koul
75eac387 6880fa6c

+1 -1
+1 -1
drivers/soundwire/debugfs.c
··· 19 19 return; 20 20 21 21 /* create the debugfs master-N */ 22 - snprintf(name, sizeof(name), "master-%d", bus->link_id); 22 + snprintf(name, sizeof(name), "master-%d-%d", bus->id, bus->link_id); 23 23 bus->debugfs = debugfs_create_dir(name, sdw_debugfs_root); 24 24 } 25 25