BUG_ON() Conversion in mm/highmem.c

this changes if() BUG(); constructs to BUG_ON() which is
cleaner, contains unlikely() and can better optimized away.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>

authored by

Eric Sesterhenn and committed by
Adrian Bunk
75babcac 9f31252c

+5 -10
+5 -10
mm/highmem.c
··· 74 pkmap_count[i] = 0; 75 76 /* sanity check */ 77 - if (pte_none(pkmap_page_table[i])) 78 - BUG(); 79 80 /* 81 * Don't need an atomic fetch-and-clear op here; ··· 157 if (!vaddr) 158 vaddr = map_new_virtual(page); 159 pkmap_count[PKMAP_NR(vaddr)]++; 160 - if (pkmap_count[PKMAP_NR(vaddr)] < 2) 161 - BUG(); 162 spin_unlock(&kmap_lock); 163 return (void*) vaddr; 164 } ··· 172 173 spin_lock(&kmap_lock); 174 vaddr = (unsigned long)page_address(page); 175 - if (!vaddr) 176 - BUG(); 177 nr = PKMAP_NR(vaddr); 178 179 /* ··· 217 return 0; 218 219 page_pool = mempool_create_page_pool(POOL_SIZE, 0); 220 - if (!page_pool) 221 - BUG(); 222 printk("highmem bounce pool size: %d pages\n", POOL_SIZE); 223 224 return 0; ··· 260 261 isa_page_pool = mempool_create(ISA_POOL_SIZE, mempool_alloc_pages_isa, 262 mempool_free_pages, (void *) 0); 263 - if (!isa_page_pool) 264 - BUG(); 265 266 printk("isa bounce pool size: %d pages\n", ISA_POOL_SIZE); 267 return 0;
··· 74 pkmap_count[i] = 0; 75 76 /* sanity check */ 77 + BUG_ON(pte_none(pkmap_page_table[i])); 78 79 /* 80 * Don't need an atomic fetch-and-clear op here; ··· 158 if (!vaddr) 159 vaddr = map_new_virtual(page); 160 pkmap_count[PKMAP_NR(vaddr)]++; 161 + BUG_ON(pkmap_count[PKMAP_NR(vaddr)] < 2); 162 spin_unlock(&kmap_lock); 163 return (void*) vaddr; 164 } ··· 174 175 spin_lock(&kmap_lock); 176 vaddr = (unsigned long)page_address(page); 177 + BUG_ON(!vaddr); 178 nr = PKMAP_NR(vaddr); 179 180 /* ··· 220 return 0; 221 222 page_pool = mempool_create_page_pool(POOL_SIZE, 0); 223 + BUG_ON(!page_pool); 224 printk("highmem bounce pool size: %d pages\n", POOL_SIZE); 225 226 return 0; ··· 264 265 isa_page_pool = mempool_create(ISA_POOL_SIZE, mempool_alloc_pages_isa, 266 mempool_free_pages, (void *) 0); 267 + BUG_ON(!isa_page_pool); 268 269 printk("isa bounce pool size: %d pages\n", ISA_POOL_SIZE); 270 return 0;