Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ocfs2: Use ERR_CAST() to avoid cross-structure cast

When trying to propagate an error result, the error return path attempts
to retain the error, but does this with an open cast across very different
types, which the upcoming structure layout randomization plugin flags as
being potentially dangerous in the face of randomization. This is a false
positive, but what this code actually wants to do is use ERR_CAST() to
retain the error value.

Cc: Mark Fasheh <mfasheh@versity.com>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Kees Cook <keescook@chromium.org>

+1 -1
+1 -1
fs/ocfs2/export.c
··· 119 119 120 120 if (IS_ERR(inode)) { 121 121 mlog_errno(PTR_ERR(inode)); 122 - result = (void *)inode; 122 + result = ERR_CAST(inode); 123 123 goto bail; 124 124 } 125 125