Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PM / OPP: Rename OPP nodes as opp@<opp-hz>

It would be better to name OPP nodes as opp@<opp-hz> as that will ensure
that multiple DT nodes don't contain the same frequency. Of course we
expect the writer to name the node with its opp-hz frequency and not any
other frequency.

And that will let the compile error out if multiple nodes are using the
same opp-hz frequency.

Suggested-by: Stephen Boyd <sboyd@codeaurora.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

authored by

Viresh Kumar and committed by
Rafael J. Wysocki
754dcf35 af87a39a

+19 -19
+19 -19
Documentation/devicetree/bindings/opp/opp.txt
··· 177 177 compatible = "operating-points-v2"; 178 178 opp-shared; 179 179 180 - opp00 { 180 + opp@1000000000 { 181 181 opp-hz = /bits/ 64 <1000000000>; 182 182 opp-microvolt = <970000 975000 985000>; 183 183 opp-microamp = <70000>; 184 184 clock-latency-ns = <300000>; 185 185 opp-suspend; 186 186 }; 187 - opp01 { 187 + opp@1100000000 { 188 188 opp-hz = /bits/ 64 <1100000000>; 189 189 opp-microvolt = <980000 1000000 1010000>; 190 190 opp-microamp = <80000>; 191 191 clock-latency-ns = <310000>; 192 192 }; 193 - opp02 { 193 + opp@1200000000 { 194 194 opp-hz = /bits/ 64 <1200000000>; 195 195 opp-microvolt = <1025000>; 196 196 clock-latency-ns = <290000>; ··· 256 256 * independently. 257 257 */ 258 258 259 - opp00 { 259 + opp@1000000000 { 260 260 opp-hz = /bits/ 64 <1000000000>; 261 261 opp-microvolt = <970000 975000 985000>; 262 262 opp-microamp = <70000>; 263 263 clock-latency-ns = <300000>; 264 264 opp-suspend; 265 265 }; 266 - opp01 { 266 + opp@1100000000 { 267 267 opp-hz = /bits/ 64 <1100000000>; 268 268 opp-microvolt = <980000 1000000 1010000>; 269 269 opp-microamp = <80000>; 270 270 clock-latency-ns = <310000>; 271 271 }; 272 - opp02 { 272 + opp@1200000000 { 273 273 opp-hz = /bits/ 64 <1200000000>; 274 274 opp-microvolt = <1025000>; 275 275 opp-microamp = <90000; ··· 332 332 compatible = "operating-points-v2"; 333 333 opp-shared; 334 334 335 - opp00 { 335 + opp@1000000000 { 336 336 opp-hz = /bits/ 64 <1000000000>; 337 337 opp-microvolt = <970000 975000 985000>; 338 338 opp-microamp = <70000>; 339 339 clock-latency-ns = <300000>; 340 340 opp-suspend; 341 341 }; 342 - opp01 { 342 + opp@1100000000 { 343 343 opp-hz = /bits/ 64 <1100000000>; 344 344 opp-microvolt = <980000 1000000 1010000>; 345 345 opp-microamp = <80000>; 346 346 clock-latency-ns = <310000>; 347 347 }; 348 - opp02 { 348 + opp@1200000000 { 349 349 opp-hz = /bits/ 64 <1200000000>; 350 350 opp-microvolt = <1025000>; 351 351 opp-microamp = <90000>; ··· 358 358 compatible = "operating-points-v2"; 359 359 opp-shared; 360 360 361 - opp10 { 361 + opp@1300000000 { 362 362 opp-hz = /bits/ 64 <1300000000>; 363 363 opp-microvolt = <1045000 1050000 1055000>; 364 364 opp-microamp = <95000>; 365 365 clock-latency-ns = <400000>; 366 366 opp-suspend; 367 367 }; 368 - opp11 { 368 + opp@1400000000 { 369 369 opp-hz = /bits/ 64 <1400000000>; 370 370 opp-microvolt = <1075000>; 371 371 opp-microamp = <100000>; 372 372 clock-latency-ns = <400000>; 373 373 }; 374 - opp12 { 374 + opp@1500000000 { 375 375 opp-hz = /bits/ 64 <1500000000>; 376 376 opp-microvolt = <1010000 1100000 1110000>; 377 377 opp-microamp = <95000>; ··· 398 398 compatible = "operating-points-v2"; 399 399 opp-shared; 400 400 401 - opp00 { 401 + opp@1000000000 { 402 402 opp-hz = /bits/ 64 <1000000000>; 403 403 opp-microvolt = <970000>, /* Supply 0 */ 404 404 <960000>, /* Supply 1 */ ··· 411 411 412 412 /* OR */ 413 413 414 - opp00 { 414 + opp@1000000000 { 415 415 opp-hz = /bits/ 64 <1000000000>; 416 416 opp-microvolt = <970000 975000 985000>, /* Supply 0 */ 417 417 <960000 965000 975000>, /* Supply 1 */ ··· 424 424 425 425 /* OR */ 426 426 427 - opp00 { 427 + opp@1000000000 { 428 428 opp-hz = /bits/ 64 <1000000000>; 429 429 opp-microvolt = <970000 975000 985000>, /* Supply 0 */ 430 430 <960000 965000 975000>, /* Supply 1 */ ··· 456 456 status = "okay"; 457 457 opp-shared; 458 458 459 - opp00 { 459 + opp@600000000 { 460 460 /* 461 461 * Supports all substrate and process versions for 0xF 462 462 * cuts, i.e. only first four cuts. ··· 467 467 ... 468 468 }; 469 469 470 - opp01 { 470 + opp@800000000 { 471 471 /* 472 472 * Supports: 473 473 * - cuts: only one, 6th cut (represented by 6th bit). ··· 499 499 compatible = "operating-points-v2"; 500 500 opp-shared; 501 501 502 - opp00 { 502 + opp@1000000000 { 503 503 opp-hz = /bits/ 64 <1000000000>; 504 504 opp-microvolt-slow = <900000 915000 925000>; 505 505 opp-microvolt-fast = <970000 975000 985000>; ··· 507 507 opp-microamp-fast = <71000>; 508 508 }; 509 509 510 - opp01 { 510 + opp@1200000000 { 511 511 opp-hz = /bits/ 64 <1200000000>; 512 512 opp-microvolt-slow = <900000 915000 925000>, /* Supply vcc0 */ 513 513 <910000 925000 935000>; /* Supply vcc1 */