Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pinctrl: at91: make it work with current gpiolib

pinctrl-at91 currently does not support the gpio-groups devicetree
property and has no pin-range.
Because of this at91 gpios stopped working since patch
commit 2ab73c6d8323fa1e ("gpio: Support GPIO controllers without pin-ranges")
This was discussed in the patches
commit fc328a7d1fcce263 ("gpio: Revert regression in sysfs-gpio (gpiolib.c)")
commit 56e337f2cf132632 ("Revert "gpio: Revert regression in sysfs-gpio (gpiolib.c)"")

As a workaround manually set pin-range via gpiochip_add_pin_range() until
a) pinctrl-at91 is reworked to support devicetree gpio-groups
b) another solution as mentioned in
commit 56e337f2cf132632 ("Revert "gpio: Revert regression in sysfs-gpio (gpiolib.c)"")
is found

Signed-off-by: Thomas Blocher <thomas.blocher@ek-dev.de>
Link: https://lore.kernel.org/5b992862-355d-f0de-cd3d-ff99e67a4ff1@ek-dev.de
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

Thomas Blocher and committed by
Linus Walleij
752f387f b7fd1033

+4 -1
+4 -1
drivers/pinctrl/pinctrl-at91.c
··· 1403 1403 1404 1404 /* We will handle a range of GPIO pins */ 1405 1405 for (i = 0; i < gpio_banks; i++) 1406 - if (gpio_chips[i]) 1406 + if (gpio_chips[i]) { 1407 1407 pinctrl_add_gpio_range(info->pctl, &gpio_chips[i]->range); 1408 + gpiochip_add_pin_range(&gpio_chips[i]->chip, dev_name(info->pctl->dev), 0, 1409 + gpio_chips[i]->range.pin_base, gpio_chips[i]->range.npins); 1410 + } 1408 1411 1409 1412 dev_info(dev, "initialized AT91 pinctrl driver\n"); 1410 1413