Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ice: remove unnecessary fallthrough comments

Fallthrough comments are used to explicitly indicate the code is intended
to flow from one case statement to the next in a switch statement rather
than break out of the switch statement. They are only needed when a case
has one or more statements to execute before falling through to the next
case, not when there is a list of cases for which the same statement(s)
should be executed.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

authored by

Bruce Allan and committed by
Jeff Kirsher
752eee06 24e2e2a0

-10
-1
drivers/net/ethernet/intel/ice/ice_base.c
··· 247 247 */ 248 248 switch (vsi->type) { 249 249 case ICE_VSI_LB: 250 - /* fall through */ 251 250 case ICE_VSI_PF: 252 251 tlan_ctx->vmvf_type = ICE_TLAN_CTX_VMVF_TYPE_PF; 253 252 break;
-2
drivers/net/ethernet/intel/ice/ice_ethtool.c
··· 1091 1091 fecparam->active_fec = ETHTOOL_FEC_BASER; 1092 1092 break; 1093 1093 case ICE_AQ_LINK_25G_RS_528_FEC_EN: 1094 - /* fall through */ 1095 1094 case ICE_AQ_LINK_25G_RS_544_FEC_EN: 1096 1095 fecparam->active_fec = ETHTOOL_FEC_RS; 1097 1096 break; ··· 1780 1781 Asym_Pause); 1781 1782 break; 1782 1783 case ICE_FC_PFC: 1783 - /* fall through */ 1784 1784 default: 1785 1785 ethtool_link_ksettings_del_link_mode(ks, lp_advertising, Pause); 1786 1786 ethtool_link_ksettings_del_link_mode(ks, lp_advertising,
-2
drivers/net/ethernet/intel/ice/ice_lib.c
··· 121 121 { 122 122 switch (vsi->type) { 123 123 case ICE_VSI_PF: 124 - /* fall through */ 125 124 case ICE_VSI_LB: 126 125 vsi->num_rx_desc = ICE_DFLT_NUM_RX_DESC; 127 126 vsi->num_tx_desc = ICE_DFLT_NUM_TX_DESC; ··· 816 817 ctxt->info = vsi->info; 817 818 switch (vsi->type) { 818 819 case ICE_VSI_LB: 819 - /* fall through */ 820 820 case ICE_VSI_PF: 821 821 ctxt->flags = ICE_AQ_VSI_TYPE_PF; 822 822 break;
-2
drivers/net/ethernet/intel/ice/ice_main.c
··· 706 706 /* Get FEC mode based on negotiated link info */ 707 707 switch (vsi->port_info->phy.link_info.fec_info) { 708 708 case ICE_AQ_LINK_25G_RS_528_FEC_EN: 709 - /* fall through */ 710 709 case ICE_AQ_LINK_25G_RS_544_FEC_EN: 711 710 fec = "RS-FEC"; 712 711 break; ··· 2954 2955 } 2955 2956 break; 2956 2957 case ICE_ERR_BUF_TOO_SHORT: 2957 - /* fall-through */ 2958 2958 case ICE_ERR_CFG: 2959 2959 dev_err(dev, "The DDP package file is invalid. Entering Safe Mode.\n"); 2960 2960 break;
-2
drivers/net/ethernet/intel/ice/ice_sriov.c
··· 121 121 speed = (u32)VIRTCHNL_LINK_SPEED_25GB; 122 122 break; 123 123 case ICE_AQ_LINK_SPEED_40GB: 124 - /* fall through */ 125 124 case ICE_AQ_LINK_SPEED_50GB: 126 - /* fall through */ 127 125 case ICE_AQ_LINK_SPEED_100GB: 128 126 speed = (u32)VIRTCHNL_LINK_SPEED_40GB; 129 127 break;
-1
drivers/net/ethernet/intel/ice/ice_txrx.c
··· 1188 1188 avg_pkt_size + 640); 1189 1189 break; 1190 1190 case ICE_AQ_LINK_SPEED_10GB: 1191 - /* fall through */ 1192 1191 default: 1193 1192 itr += DIV_ROUND_UP(170 * (avg_pkt_size + 24), 1194 1193 avg_pkt_size + 640);