Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] dib0090: Fix a warning at dib0090_set_EFUSE

The check if the values for c, h and n are within the range is
always true, as, if one of this values is out of range, the
previous "if" clauses will default to a value within the
range.

That fixes the following warning:

drivers/media/dvb-frontends/dib0090.c: In function 'dib0090_set_EFUSE':
drivers/media/dvb-frontends/dib0090.c:1545:5: warning: comparison is always true due to limited range of data type [-Wtype-limits]

and makes the code easier to read.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

+3 -7
+3 -7
drivers/media/dvb-frontends/dib0090.c
··· 1540 1540 if ((n >= POLY_MAX) || (n <= POLY_MIN)) 1541 1541 n = 3; 1542 1542 1543 - if ((c >= CAP_VALUE_MIN) && (c <= CAP_VALUE_MAX) 1544 - && (h >= HR_MIN) && (h <= HR_MAX) 1545 - && (n >= POLY_MIN) && (n <= POLY_MAX)) { 1546 - dib0090_write_reg(state, 0x13, (h << 10)); 1547 - e2 = (n << 11) | ((h >> 2)<<6) | c; 1548 - dib0090_write_reg(state, 0x2, e2); /* Load the BB_2 */ 1549 - } 1543 + dib0090_write_reg(state, 0x13, (h << 10)); 1544 + e2 = (n << 11) | ((h >> 2)<<6) | c; 1545 + dib0090_write_reg(state, 0x2, e2); /* Load the BB_2 */ 1550 1546 } 1551 1547 } 1552 1548