Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dsa: Remove phydev parameter from disable_port call

No current DSA driver makes use of the phydev parameter passed to the
disable_port call. Remove it.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Andrew Lunn and committed by
David S. Miller
75104db0 0f3b1cf2

+23 -32
+2 -2
drivers/net/dsa/b53/b53_common.c
··· 543 543 } 544 544 EXPORT_SYMBOL(b53_enable_port); 545 545 546 - void b53_disable_port(struct dsa_switch *ds, int port, struct phy_device *phy) 546 + void b53_disable_port(struct dsa_switch *ds, int port) 547 547 { 548 548 struct b53_device *dev = ds->priv; 549 549 u8 reg; ··· 963 963 if (dsa_is_cpu_port(ds, port)) 964 964 b53_enable_cpu_port(dev, port); 965 965 else if (dsa_is_unused_port(ds, port)) 966 - b53_disable_port(ds, port, NULL); 966 + b53_disable_port(ds, port); 967 967 } 968 968 969 969 return ret;
+1 -1
drivers/net/dsa/b53/b53_priv.h
··· 356 356 void b53_mirror_del(struct dsa_switch *ds, int port, 357 357 struct dsa_mall_mirror_tc_entry *mirror); 358 358 int b53_enable_port(struct dsa_switch *ds, int port, struct phy_device *phy); 359 - void b53_disable_port(struct dsa_switch *ds, int port, struct phy_device *phy); 359 + void b53_disable_port(struct dsa_switch *ds, int port); 360 360 void b53_brcm_hdr_setup(struct dsa_switch *ds, int port); 361 361 void b53_eee_enable_set(struct dsa_switch *ds, int port, bool enable); 362 362 int b53_eee_init(struct dsa_switch *ds, int port, struct phy_device *phy);
+4 -5
drivers/net/dsa/bcm_sf2.c
··· 221 221 return b53_enable_port(ds, port, phy); 222 222 } 223 223 224 - static void bcm_sf2_port_disable(struct dsa_switch *ds, int port, 225 - struct phy_device *phy) 224 + static void bcm_sf2_port_disable(struct dsa_switch *ds, int port) 226 225 { 227 226 struct bcm_sf2_priv *priv = bcm_sf2_to_priv(ds); 228 227 u32 reg; ··· 240 241 if (priv->int_phy_mask & 1 << port && priv->hw_params.num_gphy == 1) 241 242 bcm_sf2_gphy_enable_set(ds, false); 242 243 243 - b53_disable_port(ds, port, phy); 244 + b53_disable_port(ds, port); 244 245 245 246 /* Power down the port memory */ 246 247 reg = core_readl(priv, CORE_MEM_PSM_VDD_CTRL); ··· 691 692 */ 692 693 for (port = 0; port < ds->num_ports; port++) { 693 694 if (dsa_is_user_port(ds, port) || dsa_is_cpu_port(ds, port)) 694 - bcm_sf2_port_disable(ds, port, NULL); 695 + bcm_sf2_port_disable(ds, port); 695 696 } 696 697 697 698 return 0; ··· 787 788 else if (dsa_is_cpu_port(ds, port)) 788 789 bcm_sf2_imp_setup(ds, port); 789 790 else 790 - bcm_sf2_port_disable(ds, port, NULL); 791 + bcm_sf2_port_disable(ds, port); 791 792 } 792 793 793 794 b53_configure_vlan(ds);
+1 -2
drivers/net/dsa/lan9303-core.c
··· 1091 1091 return lan9303_enable_processing_port(chip, port); 1092 1092 } 1093 1093 1094 - static void lan9303_port_disable(struct dsa_switch *ds, int port, 1095 - struct phy_device *phy) 1094 + static void lan9303_port_disable(struct dsa_switch *ds, int port) 1096 1095 { 1097 1096 struct lan9303 *chip = ds->priv; 1098 1097
+2 -3
drivers/net/dsa/lantiq_gswip.c
··· 480 480 return 0; 481 481 } 482 482 483 - static void gswip_port_disable(struct dsa_switch *ds, int port, 484 - struct phy_device *phy) 483 + static void gswip_port_disable(struct dsa_switch *ds, int port) 485 484 { 486 485 struct gswip_priv *priv = ds->priv; 487 486 ··· 548 549 549 550 /* disable port fetch/store dma on all ports */ 550 551 for (i = 0; i < priv->hw_info->max_ports; i++) 551 - gswip_port_disable(ds, i, NULL); 552 + gswip_port_disable(ds, i); 552 553 553 554 /* enable Switch */ 554 555 gswip_mdio_mask(priv, 0, GSWIP_MDIO_GLOB_ENABLE, GSWIP_MDIO_GLOB);
+1 -1
drivers/net/dsa/microchip/ksz_common.c
··· 380 380 } 381 381 EXPORT_SYMBOL_GPL(ksz_enable_port); 382 382 383 - void ksz_disable_port(struct dsa_switch *ds, int port, struct phy_device *phy) 383 + void ksz_disable_port(struct dsa_switch *ds, int port) 384 384 { 385 385 struct ksz_device *dev = ds->priv; 386 386
+1 -1
drivers/net/dsa/microchip/ksz_common.h
··· 35 35 int ksz_port_mdb_del(struct dsa_switch *ds, int port, 36 36 const struct switchdev_obj_port_mdb *mdb); 37 37 int ksz_enable_port(struct dsa_switch *ds, int port, struct phy_device *phy); 38 - void ksz_disable_port(struct dsa_switch *ds, int port, struct phy_device *phy); 38 + void ksz_disable_port(struct dsa_switch *ds, int port); 39 39 40 40 /* Common register access functions */ 41 41
+2 -3
drivers/net/dsa/mt7530.c
··· 729 729 } 730 730 731 731 static void 732 - mt7530_port_disable(struct dsa_switch *ds, int port, 733 - struct phy_device *phy) 732 + mt7530_port_disable(struct dsa_switch *ds, int port) 734 733 { 735 734 struct mt7530_priv *priv = ds->priv; 736 735 ··· 1300 1301 if (dsa_is_cpu_port(ds, i)) 1301 1302 mt7530_cpu_port_enable(priv, i); 1302 1303 else 1303 - mt7530_port_disable(ds, i, NULL); 1304 + mt7530_port_disable(ds, i); 1304 1305 } 1305 1306 1306 1307 /* Flush the FDB table */
+1 -2
drivers/net/dsa/mv88e6xxx/chip.c
··· 2388 2388 return err; 2389 2389 } 2390 2390 2391 - static void mv88e6xxx_port_disable(struct dsa_switch *ds, int port, 2392 - struct phy_device *phydev) 2391 + static void mv88e6xxx_port_disable(struct dsa_switch *ds, int port) 2393 2392 { 2394 2393 struct mv88e6xxx_chip *chip = ds->priv; 2395 2394
+1 -2
drivers/net/dsa/qca8k.c
··· 801 801 } 802 802 803 803 static void 804 - qca8k_port_disable(struct dsa_switch *ds, int port, 805 - struct phy_device *phy) 804 + qca8k_port_disable(struct dsa_switch *ds, int port) 806 805 { 807 806 struct qca8k_priv *priv = (struct qca8k_priv *)ds->priv; 808 807
+1 -2
drivers/net/dsa/rtl8366rb.c
··· 1073 1073 } 1074 1074 1075 1075 static void 1076 - rtl8366rb_port_disable(struct dsa_switch *ds, int port, 1077 - struct phy_device *phy) 1076 + rtl8366rb_port_disable(struct dsa_switch *ds, int port) 1078 1077 { 1079 1078 struct realtek_smi *smi = ds->priv; 1080 1079 int ret;
+1 -2
drivers/net/dsa/vitesse-vsc73xx.c
··· 1013 1013 return 0; 1014 1014 } 1015 1015 1016 - static void vsc73xx_port_disable(struct dsa_switch *ds, int port, 1017 - struct phy_device *phy) 1016 + static void vsc73xx_port_disable(struct dsa_switch *ds, int port) 1018 1017 { 1019 1018 struct vsc73xx *vsc = ds->priv; 1020 1019
+1 -2
include/net/dsa.h
··· 364 364 */ 365 365 int (*port_enable)(struct dsa_switch *ds, int port, 366 366 struct phy_device *phy); 367 - void (*port_disable)(struct dsa_switch *ds, int port, 368 - struct phy_device *phy); 367 + void (*port_disable)(struct dsa_switch *ds, int port); 369 368 370 369 /* 371 370 * Port's MAC EEE settings
+1 -1
net/dsa/dsa_priv.h
··· 143 143 int dsa_port_set_state(struct dsa_port *dp, u8 state, 144 144 struct switchdev_trans *trans); 145 145 int dsa_port_enable(struct dsa_port *dp, struct phy_device *phy); 146 - void dsa_port_disable(struct dsa_port *dp, struct phy_device *phy); 146 + void dsa_port_disable(struct dsa_port *dp); 147 147 int dsa_port_bridge_join(struct dsa_port *dp, struct net_device *br); 148 148 void dsa_port_bridge_leave(struct dsa_port *dp, struct net_device *br); 149 149 int dsa_port_vlan_filtering(struct dsa_port *dp, bool vlan_filtering,
+2 -2
net/dsa/port.c
··· 85 85 return 0; 86 86 } 87 87 88 - void dsa_port_disable(struct dsa_port *dp, struct phy_device *phy) 88 + void dsa_port_disable(struct dsa_port *dp) 89 89 { 90 90 struct dsa_switch *ds = dp->ds; 91 91 int port = dp->index; ··· 94 94 dsa_port_set_state_now(dp, BR_STATE_DISABLED); 95 95 96 96 if (ds->ops->port_disable) 97 - ds->ops->port_disable(ds, port, phy); 97 + ds->ops->port_disable(ds, port); 98 98 } 99 99 100 100 int dsa_port_bridge_join(struct dsa_port *dp, struct net_device *br)
+1 -1
net/dsa/slave.c
··· 122 122 123 123 phylink_stop(dp->pl); 124 124 125 - dsa_port_disable(dp, dev->phydev); 125 + dsa_port_disable(dp); 126 126 127 127 dev_mc_unsync(master, dev); 128 128 dev_uc_unsync(master, dev);