Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/gma500: Remove unnecessary suspend/resume wrappers

The psb_runtime_suspend/resume/thaw/freeze/restore functions are all
just 1:1 wrappers around gma_power_suspend/_resume.

Drop these wrappers and use the DEFINE_RUNTIME_DEV_PM_OPS() macro to
define the dev_pm_ops struct.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220909115646.99920-7-hdegoede@redhat.com

+1 -43
-25
drivers/gpu/drm/gma500/power.c
··· 230 230 { 231 231 pm_runtime_put(dev->dev); 232 232 } 233 - 234 - int psb_runtime_suspend(struct device *dev) 235 - { 236 - return gma_power_suspend(dev); 237 - } 238 - 239 - int psb_runtime_resume(struct device *dev) 240 - { 241 - return gma_power_resume(dev); 242 - } 243 - 244 - int gma_power_thaw(struct device *_dev) 245 - { 246 - return gma_power_resume(_dev); 247 - } 248 - 249 - int gma_power_freeze(struct device *_dev) 250 - { 251 - return gma_power_suspend(_dev); 252 - } 253 - 254 - int gma_power_restore(struct device *_dev) 255 - { 256 - return gma_power_resume(_dev); 257 - }
-9
drivers/gpu/drm/gma500/power.h
··· 43 43 */ 44 44 int gma_power_suspend(struct device *dev); 45 45 int gma_power_resume(struct device *dev); 46 - int gma_power_thaw(struct device *dev); 47 - int gma_power_freeze(struct device *dev); 48 - int gma_power_restore(struct device *_dev); 49 46 50 47 /* 51 48 * These are the functions the driver should use to wrap all hw access ··· 50 53 */ 51 54 bool gma_power_begin(struct drm_device *dev, bool force); 52 55 void gma_power_end(struct drm_device *dev); 53 - 54 - /* 55 - * GFX-Runtime PM callbacks 56 - */ 57 - int psb_runtime_suspend(struct device *dev); 58 - int psb_runtime_resume(struct device *dev); 59 56 60 57 #endif /*_PSB_POWERMGMT_H_*/
+1 -9
drivers/gpu/drm/gma500/psb_drv.c
··· 471 471 drm_dev_unregister(dev); 472 472 } 473 473 474 - static const struct dev_pm_ops psb_pm_ops = { 475 - .resume = gma_power_resume, 476 - .suspend = gma_power_suspend, 477 - .thaw = gma_power_thaw, 478 - .freeze = gma_power_freeze, 479 - .restore = gma_power_restore, 480 - .runtime_suspend = psb_runtime_suspend, 481 - .runtime_resume = psb_runtime_resume, 482 - }; 474 + static DEFINE_RUNTIME_DEV_PM_OPS(psb_pm_ops, gma_power_suspend, gma_power_resume, NULL); 483 475 484 476 static const struct file_operations psb_gem_fops = { 485 477 .owner = THIS_MODULE,