Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf tools: Add missing sigqueue() prototype for systems lacking it

There are systems such as the Android NDK API level 24 has the
sigqueue() function but doesn't provide a prototype, adding noise to the
build:

util/evlist.c: In function 'perf_evlist__prepare_workload':
util/evlist.c:1494:4: warning: implicit declaration of function 'sigqueue' [-Wimplicit-function-declaration]
if (sigqueue(getppid(), SIGUSR1, val))
^
util/evlist.c:1494:4: warning: nested extern declaration of 'sigqueue' [-Wnested-externs]

Define a LACKS_SIGQUEUE_PROTOTYPE define so that code needing that can
get a prototype.

Checked in the bionic git repo to be available since level 23:

https://android.googlesource.com/platform/bionic/+/master/libc/include/signal.h#123

int sigqueue(pid_t __pid, int __signal, const union sigval __value) __INTRODUCED_IN(23);

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-lmhpev1uni9kdrv7j29glyov@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

+5
+1
tools/perf/Makefile.config
··· 294 294 $(call feature_check,bionic) 295 295 ifeq ($(feature-bionic), 1) 296 296 BIONIC := 1 297 + CFLAGS += -DLACKS_SIGQUEUE_PROTOTYPE 297 298 EXTLIBS := $(filter-out -lrt,$(EXTLIBS)) 298 299 EXTLIBS := $(filter-out -lpthread,$(EXTLIBS)) 299 300 endif
+4
tools/perf/util/evlist.c
··· 34 34 #include <linux/log2.h> 35 35 #include <linux/err.h> 36 36 37 + #ifdef LACKS_SIGQUEUE_PROTOTYPE 38 + int sigqueue(pid_t pid, int sig, const union sigval value); 39 + #endif 40 + 37 41 #define FD(e, x, y) (*(int *)xyarray__entry(e->fd, x, y)) 38 42 #define SID(e, x, y) xyarray__entry(e->sample_id, x, y) 39 43