Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: phy: keystone: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230319092428.283054-7-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Uwe Kleine-König and committed by
Greg Kroah-Hartman
744e004b 399d0117

+2 -4
+2 -4
drivers/usb/phy/phy-keystone.c
··· 88 88 return usb_add_phy_dev(&k_phy->usb_phy_gen.phy); 89 89 } 90 90 91 - static int keystone_usbphy_remove(struct platform_device *pdev) 91 + static void keystone_usbphy_remove(struct platform_device *pdev) 92 92 { 93 93 struct keystone_usbphy *k_phy = platform_get_drvdata(pdev); 94 94 95 95 usb_remove_phy(&k_phy->usb_phy_gen.phy); 96 - 97 - return 0; 98 96 } 99 97 100 98 static const struct of_device_id keystone_usbphy_ids[] = { ··· 103 105 104 106 static struct platform_driver keystone_usbphy_driver = { 105 107 .probe = keystone_usbphy_probe, 106 - .remove = keystone_usbphy_remove, 108 + .remove_new = keystone_usbphy_remove, 107 109 .driver = { 108 110 .name = "keystone-usbphy", 109 111 .of_match_table = keystone_usbphy_ids,