Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

soc: qcom: rpmh: Update rpmh_invalidate function to return void

Currently rpmh_invalidate() always returns success. Update its
return type to void.

Reviewed-by: Lina Iyer <ilina@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Suggested-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
Link: https://lore.kernel.org/r/1592485553-29163-1-git-send-email-mkshah@codeaurora.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

authored by

Maulik Shah and committed by
Bjorn Andersson
73edcd38 681b0912

+6 -11
+1 -5
drivers/interconnect/qcom/bcm-voter.c
··· 266 266 if (!commit_idx[0]) 267 267 goto out; 268 268 269 - ret = rpmh_invalidate(voter->dev); 270 - if (ret) { 271 - pr_err("Error invalidating RPMH client (%d)\n", ret); 272 - goto out; 273 - } 269 + rpmh_invalidate(voter->dev); 274 270 275 271 ret = rpmh_write_batch(voter->dev, RPMH_ACTIVE_ONLY_STATE, 276 272 cmds, commit_idx);
+1 -3
drivers/soc/qcom/rpmh.c
··· 497 497 * 498 498 * Invalidate the sleep and wake values in batch_cache. 499 499 */ 500 - int rpmh_invalidate(const struct device *dev) 500 + void rpmh_invalidate(const struct device *dev) 501 501 { 502 502 struct rpmh_ctrlr *ctrlr = get_rpmh_ctrlr(dev); 503 503 struct batch_cache_req *req, *tmp; ··· 509 509 INIT_LIST_HEAD(&ctrlr->batch_cache); 510 510 ctrlr->dirty = true; 511 511 spin_unlock_irqrestore(&ctrlr->cache_lock, flags); 512 - 513 - return 0; 514 512 } 515 513 EXPORT_SYMBOL(rpmh_invalidate);
+4 -3
include/soc/qcom/rpmh.h
··· 20 20 int rpmh_write_batch(const struct device *dev, enum rpmh_state state, 21 21 const struct tcs_cmd *cmd, u32 *n); 22 22 23 - int rpmh_invalidate(const struct device *dev); 23 + void rpmh_invalidate(const struct device *dev); 24 24 25 25 #else 26 26 ··· 38 38 const struct tcs_cmd *cmd, u32 *n) 39 39 { return -ENODEV; } 40 40 41 - static inline int rpmh_invalidate(const struct device *dev) 42 - { return -ENODEV; } 41 + static inline void rpmh_invalidate(const struct device *dev) 42 + { 43 + } 43 44 44 45 #endif /* CONFIG_QCOM_RPMH */ 45 46