Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Input: navpoint - pass correct pointer to free_irq()

free_irq() expects the same pointer that was passed to request_irq(),
otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Lars-Peter Clausen and committed by
Dmitry Torokhov
737f644c 139097a0

+1 -1
+1 -1
drivers/input/mouse/navpoint.c
··· 287 287 return 0; 288 288 289 289 err_free_irq: 290 - free_irq(ssp->irq, &pdev->dev); 290 + free_irq(ssp->irq, navpoint); 291 291 err_free_mem: 292 292 input_free_device(input); 293 293 kfree(navpoint);