Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf tools: Remove perf_tool from event_op3

Now that we keep a perf_tool pointer inside perf_session, there's no need
to have a perf_tool argument in the event_op3 callback. Remove it.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180913125450.21342-3-jolsa@kernel.org
[ Fix the builtin-inject.c build for !HAVE_AUXTRACE_SUPPORT ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

authored by

Jiri Olsa and committed by
Arnaldo Carvalho de Melo
7336555a 89f1688a

+14 -21
+5 -6
tools/perf/builtin-inject.c
··· 131 131 return 0; 132 132 } 133 133 134 - static s64 perf_event__repipe_auxtrace(struct perf_tool *tool, 135 - union perf_event *event, 136 - struct perf_session *session) 134 + static s64 perf_event__repipe_auxtrace(struct perf_session *session, 135 + union perf_event *event) 137 136 { 137 + struct perf_tool *tool = session->tool; 138 138 struct perf_inject *inject = container_of(tool, struct perf_inject, 139 139 tool); 140 140 int ret; ··· 172 172 #else 173 173 174 174 static s64 175 - perf_event__repipe_auxtrace(struct perf_tool *tool __maybe_unused, 176 - union perf_event *event __maybe_unused, 177 - struct perf_session *session __maybe_unused) 175 + perf_event__repipe_auxtrace(struct perf_session *session __maybe_unused, 176 + union perf_event *event __maybe_unused) 178 177 { 179 178 pr_err("AUX area tracing not supported\n"); 180 179 return -EINVAL;
+3 -4
tools/perf/util/auxtrace.c
··· 931 931 } 932 932 } 933 933 934 - s64 perf_event__process_auxtrace(struct perf_tool *tool, 935 - union perf_event *event, 936 - struct perf_session *session) 934 + s64 perf_event__process_auxtrace(struct perf_session *session, 935 + union perf_event *event) 937 936 { 938 937 s64 err; 939 938 ··· 948 949 if (!session->auxtrace || event->header.type != PERF_RECORD_AUXTRACE) 949 950 return -EINVAL; 950 951 951 - err = session->auxtrace->process_auxtrace_event(session, event, tool); 952 + err = session->auxtrace->process_auxtrace_event(session, event, session->tool); 952 953 if (err < 0) 953 954 return err; 954 955
+2 -3
tools/perf/util/auxtrace.h
··· 519 519 perf_event__handler_t process); 520 520 int perf_event__process_auxtrace_info(struct perf_session *session, 521 521 union perf_event *event); 522 - s64 perf_event__process_auxtrace(struct perf_tool *tool, 523 - union perf_event *event, 524 - struct perf_session *session); 522 + s64 perf_event__process_auxtrace(struct perf_session *session, 523 + union perf_event *event); 525 524 int perf_event__process_auxtrace_error(struct perf_session *session, 526 525 union perf_event *event); 527 526 int itrace_parse_synth_opts(const struct option *opt, const char *str,
+3 -5
tools/perf/util/session.c
··· 275 275 return 0; 276 276 } 277 277 278 - static s64 process_event_auxtrace_stub(struct perf_tool *tool __maybe_unused, 279 - union perf_event *event, 280 - struct perf_session *session 281 - __maybe_unused) 278 + static s64 process_event_auxtrace_stub(struct perf_session *session __maybe_unused, 279 + union perf_event *event) 282 280 { 283 281 dump_printf(": unhandled!\n"); 284 282 if (perf_data__is_pipe(session->data)) ··· 1374 1376 case PERF_RECORD_AUXTRACE: 1375 1377 /* setup for reading amidst mmap */ 1376 1378 lseek(fd, file_offset + event->header.size, SEEK_SET); 1377 - return tool->auxtrace(tool, event, session); 1379 + return tool->auxtrace(session, event); 1378 1380 case PERF_RECORD_AUXTRACE_ERROR: 1379 1381 perf_session__auxtrace_error_inc(session, event); 1380 1382 return tool->auxtrace_error(session, event);
+1 -3
tools/perf/util/tool.h
··· 27 27 struct perf_evlist **pevlist); 28 28 29 29 typedef int (*event_op2)(struct perf_session *session, union perf_event *event); 30 + typedef s64 (*event_op3)(struct perf_session *session, union perf_event *event); 30 31 31 32 typedef int (*event_oe)(struct perf_tool *tool, union perf_event *event, 32 33 struct ordered_events *oe); 33 - 34 - typedef s64 (*event_op3)(struct perf_tool *tool, union perf_event *event, 35 - struct perf_session *session); 36 34 37 35 enum show_feature_header { 38 36 SHOW_FEAT_NO_HEADER = 0,