Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

tty: evh_bytechan: Replace NO_IRQ by 0

NO_IRQ is used to check the return of irq_of_parse_and_map().

On some architecture NO_IRQ is 0, on other architectures it is -1.

irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.

So use 0 instead of using NO_IRQ.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Acked-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Link: https://lore.kernel.org/r/23f608ca57e7e19bc7060d3e563de383e0b2b337.1665033575.git.christophe.leroy@csgroup.eu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Christophe Leroy and committed by
Greg Kroah-Hartman
72da688b f58a1604

+2 -2
+2 -2
drivers/tty/ehv_bytechan.c
··· 118 118 return 0; 119 119 120 120 stdout_irq = irq_of_parse_and_map(np, 0); 121 - if (stdout_irq == NO_IRQ) { 121 + if (!stdout_irq) { 122 122 pr_err("ehv-bc: no 'interrupts' property in %pOF node\n", np); 123 123 return 0; 124 124 } ··· 696 696 697 697 bc->rx_irq = irq_of_parse_and_map(np, 0); 698 698 bc->tx_irq = irq_of_parse_and_map(np, 1); 699 - if ((bc->rx_irq == NO_IRQ) || (bc->tx_irq == NO_IRQ)) { 699 + if (!bc->rx_irq || !bc->tx_irq) { 700 700 dev_err(&pdev->dev, "no 'interrupts' property in %pOFn node\n", 701 701 np); 702 702 ret = -ENODEV;