Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwmon: (gpd-fan) Fix error handling in gpd_fan_probe()

devm_request_region() returns a NULL pointer on error, not an ERR_PTR().
Handle it accordingly.

Also fix error return from the call to devm_hwmon_device_register_with_info().

Fixes: 0ab88e239439 ("hwmon: add GPD devices sensor driver")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Cryolitia PukNgae <cryolitia@uniontech.com>
Link: https://lore.kernel.org/r/20251010204447.94343-1-harshit.m.mogalapalli@oracle.com
[groeck: Updated subject to improve readability]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

authored by

Harshit Mogalapalli and committed by
Guenter Roeck
72ac1485 ab0fd09d

+3 -3
+3 -3
drivers/hwmon/gpd-fan.c
··· 621 621 622 622 region = devm_request_region(dev, res->start, 623 623 resource_size(res), DRIVER_NAME); 624 - if (IS_ERR(region)) 625 - return dev_err_probe(dev, PTR_ERR(region), 624 + if (!region) 625 + return dev_err_probe(dev, -EBUSY, 626 626 "Failed to request region\n"); 627 627 628 628 hwdev = devm_hwmon_device_register_with_info(dev, ··· 631 631 &gpd_fan_chip_info, 632 632 NULL); 633 633 if (IS_ERR(hwdev)) 634 - return dev_err_probe(dev, PTR_ERR(region), 634 + return dev_err_probe(dev, PTR_ERR(hwdev), 635 635 "Failed to register hwmon device\n"); 636 636 637 637 return 0;