PCI: pci_slot: grab refcount on slot's bus

If a logical hot unplug (remove) is performed on a physical PCI slot's
parent bridge, and then pci_slot is unloaded, we will encounter an oops:

[<ffffffff803a788a>] kobject_release+0x9a/0x290
[<ffffffff803a77f0>] ? kobject_release+0x0/0x290
[<ffffffff803a8ce7>] kref_put+0x37/0x80
[<ffffffff803a76f7>] kobject_put+0x27/0x60
[<ffffffff803bebcc>] ? pci_destroy_slot+0x3c/0xc0
[<ffffffff803bebd5>] pci_destroy_slot+0x45/0xc0
[<ffffffffa000f05c>] acpi_pci_slot_remove+0x5c/0x91 [pci_slot]
[<ffffffff8040064b>] acpi_pci_unregister_driver+0x4b/0x62
[<ffffffffa000f5c8>] acpi_pci_slot_exit+0x10/0x12 [pci_slot]
[<ffffffff80276ce1>] sys_delete_module+0x161/0x250

We need to grab a reference to the parent PCI bus, which will pin
the bus and prevent it from being released until pci_slot is unloaded.

Cc: lenb@kernel.org
Reviewed-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Tested-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Reported-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Alex Chiang <achiang@hp.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

authored by Alex Chiang and committed by Jesse Barnes 72800360 5d4a4b25

+5
+5
drivers/acpi/pci_slot.c
··· 164 list_add(&slot->list, &slot_list); 165 mutex_unlock(&slot_list_lock); 166 167 dbg("pci_slot: %p, pci_bus: %x, device: %d, name: %s\n", 168 pci_slot, pci_bus->number, device, name); 169 ··· 312 acpi_pci_slot_remove(acpi_handle handle) 313 { 314 struct acpi_pci_slot *slot, *tmp; 315 316 mutex_lock(&slot_list_lock); 317 list_for_each_entry_safe(slot, tmp, &slot_list, list) { 318 if (slot->root_handle == handle) { 319 list_del(&slot->list); 320 pci_destroy_slot(slot->pci_slot); 321 kfree(slot); 322 } 323 }
··· 164 list_add(&slot->list, &slot_list); 165 mutex_unlock(&slot_list_lock); 166 167 + get_device(&pci_bus->dev); 168 + 169 dbg("pci_slot: %p, pci_bus: %x, device: %d, name: %s\n", 170 pci_slot, pci_bus->number, device, name); 171 ··· 310 acpi_pci_slot_remove(acpi_handle handle) 311 { 312 struct acpi_pci_slot *slot, *tmp; 313 + struct pci_bus *pbus; 314 315 mutex_lock(&slot_list_lock); 316 list_for_each_entry_safe(slot, tmp, &slot_list, list) { 317 if (slot->root_handle == handle) { 318 list_del(&slot->list); 319 + pbus = slot->pci_slot->bus; 320 pci_destroy_slot(slot->pci_slot); 321 + put_device(&pbus->dev); 322 kfree(slot); 323 } 324 }