Staging: dwc2: Fix variable dereferenced before check

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

This patch fixes the following smatch warning in hcd_intr.c-
drivers/staging/dwc2/hcd_intr.c:1946 dwc2_hc_n_intr() warn: variable dereferenced before check 'chan' (see line 1936)

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Rashika Kheria and committed by

Greg Kroah-Hartman 12 years ago 723a2311 4759e824

+8 -9

1 changed file

expand all

drivers

staging

dwc2

hcd_intr.c

+8 -9

drivers/staging/dwc2/hcd_intr.c

··· 1932 1932 1933 1933 chan = hsotg->hc_ptr_array[chnum]; 1934 1934 1935 - if (dbg_hc(chan)) 1936 - dev_vdbg(hsotg->dev, "--Host Channel Interrupt--, Channel %d\n", 1937 - chnum); 1938 - 1939 1935 hcint = readl(hsotg->regs + HCINT(chnum)); 1940 1936 hcintmsk = readl(hsotg->regs + HCINTMSK(chnum)); 1941 - if (dbg_hc(chan)) 1942 - dev_vdbg(hsotg->dev, 1943 - " hcint 0x%08x, hcintmsk 0x%08x, hcint&hcintmsk 0x%08x\n", 1944 - hcint, hcintmsk, hcint & hcintmsk); 1945 - 1946 1937 if (!chan) { 1947 1938 dev_err(hsotg->dev, "## hc_ptr_array for channel is NULL ##\n"); 1948 1939 writel(hcint, hsotg->regs + HCINT(chnum)); 1949 1940 return; 1941 + } 1942 + 1943 + if (dbg_hc(chan)) { 1944 + dev_vdbg(hsotg->dev, "--Host Channel Interrupt--, Channel %d\n", 1945 + chnum); 1946 + dev_vdbg(hsotg->dev, 1947 + " hcint 0x%08x, hcintmsk 0x%08x, hcint&hcintmsk 0x%08x\n", 1948 + hcint, hcintmsk, hcint & hcintmsk); 1950 1949 } 1951 1950 1952 1951 writel(hcint, hsotg->regs + HCINT(chnum));