Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

spi: microchip-core: Clean up redundant dev_err_probe()

Refering to platform_get_irq()'s definition, the return value has
already been checked if ret < 0, and printed via dev_err_probe().
Calling dev_err_probe() one more time outside platform_get_irq()
is obviously redundant.

Furthermore, platform_get_irq() will never return irq equals 0,
removing spi->irq == 0 checking to clean it up.

Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20230728075729.3451867-1-chenjiahao16@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Chen Jiahao and committed by
Mark Brown
71ee2a4f 026badeb

+2 -4
+2 -4
drivers/spi/spi-microchip-core.c
··· 530 530 return PTR_ERR(spi->regs); 531 531 532 532 spi->irq = platform_get_irq(pdev, 0); 533 - if (spi->irq <= 0) 534 - return dev_err_probe(&pdev->dev, -ENXIO, 535 - "invalid IRQ %d for SPI controller\n", 536 - spi->irq); 533 + if (spi->irq < 0) 534 + return spi->irq; 537 535 538 536 ret = devm_request_irq(&pdev->dev, spi->irq, mchp_corespi_interrupt, 539 537 IRQF_SHARED, dev_name(&pdev->dev), master);