Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: rtl8712: Use ether_addr_copy() instead of memcpy()

Fixes Warning encounter this by applying checkpatch.pl against this file:
Prefer ether_addr_copy() over memcpy() if the Ethernet addresses
are __aligned(2)

pahole output for respective structures:
- addr->sa_data
struct sockaddr {
sa_family_t sa_family; /* 0 2 */
char sa_data[14]; /* 2 14 */

/* size: 16, cachelines: 1, members: 2 */
/* last cacheline: 16 bytes */
};

- pnetdev->dev_addr
dev_addr is interface address infor from generic net_device structure
which is properly aligned and have some patches with this change as well.
"staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()"
(sha1: 36e4d8826b317080e283e4edd08bf8d5ac706f38)

Signed-off-by: Jagan Teki <jteki@openedev.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Jagan Teki and committed by
Greg Kroah-Hartman
71d667b8 0a36d5fb

+1 -1
+1 -1
drivers/staging/rtl8712/os_intfs.c
··· 181 181 struct sockaddr *addr = p; 182 182 183 183 if (padapter->bup == false) 184 - memcpy(pnetdev->dev_addr, addr->sa_data, ETH_ALEN); 184 + ether_addr_copy(pnetdev->dev_addr, addr->sa_data); 185 185 return 0; 186 186 } 187 187