tjh.dev
Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
net: wan: add necessary () to macro argument
Macro argument 'card' and 'port' may be better as
'(card)' and '(port)' to avoid precedence issues.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
authored by
Peng Li
and committed by
David S. Miller
70fe4523
1bf705d4
+9
-9
+9
-9
drivers/net/wan/hd64572.c
+9
-9
drivers/net/wan/hd64572.c
···
41
41
42
42
#define NAPI_WEIGHT 16
43
43
44
-
#define get_msci(port) (port->chan ? MSCI1_OFFSET : MSCI0_OFFSET)
45
-
#define get_dmac_rx(port) (port->chan ? DMAC1RX_OFFSET : DMAC0RX_OFFSET)
46
-
#define get_dmac_tx(port) (port->chan ? DMAC1TX_OFFSET : DMAC0TX_OFFSET)
44
+
#define get_msci(port) ((port)->chan ? MSCI1_OFFSET : MSCI0_OFFSET)
45
+
#define get_dmac_rx(port) ((port)->chan ? DMAC1RX_OFFSET : DMAC0RX_OFFSET)
46
+
#define get_dmac_tx(port) ((port)->chan ? DMAC1TX_OFFSET : DMAC0TX_OFFSET)
47
47
48
-
#define sca_in(reg, card) readb(card->scabase + (reg))
49
-
#define sca_out(value, reg, card) writeb(value, card->scabase + (reg))
50
-
#define sca_inw(reg, card) readw(card->scabase + (reg))
51
-
#define sca_outw(value, reg, card) writew(value, card->scabase + (reg))
52
-
#define sca_inl(reg, card) readl(card->scabase + (reg))
53
-
#define sca_outl(value, reg, card) writel(value, card->scabase + (reg))
48
+
#define sca_in(reg, card) readb((card)->scabase + (reg))
49
+
#define sca_out(value, reg, card) writeb(value, (card)->scabase + (reg))
50
+
#define sca_inw(reg, card) readw((card)->scabase + (reg))
51
+
#define sca_outw(value, reg, card) writew(value, (card)->scabase + (reg))
52
+
#define sca_inl(reg, card) readl((card)->scabase + (reg))
53
+
#define sca_outl(value, reg, card) writel(value, (card)->scabase + (reg))
54
54
55
55
static int sca_poll(struct napi_struct *napi, int budget);
56
56