Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/tests: cmdline: Fix drm_display_mode memory leak

drm_analog_tv_mode() and its variants return a drm_display_mode that
needs to be destroyed later one. The drm_test_cmdline_tv_options() test
never does however, which leads to a memory leak.

Let's make sure it's freed.

Reported-by: Philipp Stanner <phasta@mailbox.org>
Closes: https://lore.kernel.org/dri-devel/a7655158a6367ac46194d57f4b7433ef0772a73e.camel@mailbox.org/
Fixes: e691c9992ae1 ("drm/modes: Introduce the tv_mode property as a command-line option")
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20250408-drm-kunit-drm-display-mode-memleak-v1-4-996305a2e75a@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>

+9 -1
+9 -1
drivers/gpu/drm/tests/drm_cmdline_parser_test.c
··· 7 7 #include <kunit/test.h> 8 8 9 9 #include <drm/drm_connector.h> 10 + #include <drm/drm_kunit_helpers.h> 10 11 #include <drm/drm_modes.h> 11 12 12 13 static const struct drm_connector no_connector = {}; ··· 956 955 static void drm_test_cmdline_tv_options(struct kunit *test) 957 956 { 958 957 const struct drm_cmdline_tv_option_test *params = test->param_value; 959 - const struct drm_display_mode *expected_mode = params->mode_fn(NULL); 958 + struct drm_display_mode *expected_mode; 960 959 struct drm_cmdline_mode mode = { }; 960 + int ret; 961 + 962 + expected_mode = params->mode_fn(NULL); 963 + KUNIT_ASSERT_NOT_NULL(test, expected_mode); 964 + 965 + ret = drm_kunit_add_mode_destroy_action(test, expected_mode); 966 + KUNIT_ASSERT_EQ(test, ret, 0); 961 967 962 968 KUNIT_EXPECT_TRUE(test, drm_mode_parse_command_line_for_connector(params->cmdline, 963 969 &no_connector, &mode));