Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

tools/mm/page_owner_sort: fix timestamp comparison for stable sorting

The ternary operator in compare_ts() returns 1 when timestamps are equal,
causing unstable sorting behavior. Replace with explicit three-way
comparison that returns 0 for equal timestamps, ensuring stable qsort
ordering and consistent output.

Link: https://lkml.kernel.org/r/20251209044552.3396468-1-kaushlendra.kumar@intel.com
Fixes: 8f9c447e2e2b ("tools/vm/page_owner_sort.c: support sorting pid and time")
Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Cc: Chongxi Zhao <zhaochongxi2019@email.szu.edu.cn>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Kaushlendra Kumar and committed by
Andrew Morton
70138034 632b874d

+5 -1
+5 -1
tools/mm/page_owner_sort.c
··· 181 181 { 182 182 const struct block_list *l1 = p1, *l2 = p2; 183 183 184 - return l1->ts_nsec < l2->ts_nsec ? -1 : 1; 184 + if (l1->ts_nsec < l2->ts_nsec) 185 + return -1; 186 + if (l1->ts_nsec > l2->ts_nsec) 187 + return 1; 188 + return 0; 185 189 } 186 190 187 191 static int compare_cull_condition(const void *p1, const void *p2)