firmware: Always initialize the fw_priv list object

When freeing the fw_priv the item is taken off the list. This causes an
oops in the FW_OPT_NOCACHE case as the list object is not initialized.

Make sure to initialize the list object regardless of this flag.

Fixes: 422b3db2a503 ("firmware: Fix security issue with request_firmware_into_buf()")
Cc: stable@vger.kernel.org
Cc: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by Bjorn Andersson and committed by Greg Kroah-Hartman 70120405 492ecf6d

Changed files
+5 -2
drivers
base
firmware_loader
+5 -2
drivers/base/firmware_loader/main.c
··· 226 226 } 227 227 228 228 tmp = __allocate_fw_priv(fw_name, fwc, dbuf, size); 229 - if (tmp && !(opt_flags & FW_OPT_NOCACHE)) 230 - list_add(&tmp->list, &fwc->head); 229 + if (tmp) { 230 + INIT_LIST_HEAD(&tmp->list); 231 + if (!(opt_flags & FW_OPT_NOCACHE)) 232 + list_add(&tmp->list, &fwc->head); 233 + } 231 234 spin_unlock(&fwc->lock); 232 235 233 236 *fw_priv = tmp;