Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: vimc: fill in bus_info in media_device_info

It is good practice to fill in bus_info.

Also just use 'platform:vimc' when filling in the bus_info in querycap:
the bus_info has nothing to do with the video device name.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: Helen Koike <helen.koike@collabora.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

authored by

Hans Verkuil and committed by
Mauro Carvalho Chehab
6fd369dd db89a47f

+3 -3
+1 -3
drivers/media/platform/vimc/vimc-capture.c
··· 70 70 static int vimc_cap_querycap(struct file *file, void *priv, 71 71 struct v4l2_capability *cap) 72 72 { 73 - struct vimc_cap_device *vcap = video_drvdata(file); 74 - 75 73 strscpy(cap->driver, VIMC_PDEV_NAME, sizeof(cap->driver)); 76 74 strscpy(cap->card, KBUILD_MODNAME, sizeof(cap->card)); 77 75 snprintf(cap->bus_info, sizeof(cap->bus_info), 78 - "platform:%s", vcap->vdev.v4l2_dev->name); 76 + "platform:%s", VIMC_PDEV_NAME); 79 77 80 78 return 0; 81 79 }
+2
drivers/media/platform/vimc/vimc-core.c
··· 318 318 /* Initialize media device */ 319 319 strscpy(vimc->mdev.model, VIMC_MDEV_MODEL_NAME, 320 320 sizeof(vimc->mdev.model)); 321 + snprintf(vimc->mdev.bus_info, sizeof(vimc->mdev.bus_info), 322 + "platform:%s", VIMC_PDEV_NAME); 321 323 vimc->mdev.dev = &pdev->dev; 322 324 media_device_init(&vimc->mdev); 323 325