tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

Revert "net: usb: ax88179_178a needs FLAG_SEND_ZLP"

This reverts commit 36a15e1cb134c0395261ba1940762703f778438c.

The usage of FLAG_SEND_ZLP causes problems to other firmware/hardware
versions that have no issues.

The FLAG_SEND_ZLP is not safe to use in this context.
See:
https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Linuxdev4-laptop/#118378
The original problem needs another way to solve.

Fixes: 36a15e1cb134 ("net: usb: ax88179_178a needs FLAG_SEND_ZLP")
Cc: stable@vger.kernel.org
Reported-by: Ronald Wahl <ronald.wahl@raritan.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216327
Link: https://bugs.archlinux.org/task/75491
Signed-off-by: Jose Alonso <joalonsof@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Jose Alonso and committed by
David S. Miller 6fd2c17f 2cd0e8db

+13 -13
+13 -13
drivers/net/usb/ax88179_178a.c
··· 1680 1680 .link_reset = ax88179_link_reset, 1681 1681 .reset = ax88179_reset, 1682 1682 .stop = ax88179_stop, 1683 - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, 1683 + .flags = FLAG_ETHER | FLAG_FRAMING_AX, 1684 1684 .rx_fixup = ax88179_rx_fixup, 1685 1685 .tx_fixup = ax88179_tx_fixup, 1686 1686 }; ··· 1693 1693 .link_reset = ax88179_link_reset, 1694 1694 .reset = ax88179_reset, 1695 1695 .stop = ax88179_stop, 1696 - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, 1696 + .flags = FLAG_ETHER | FLAG_FRAMING_AX, 1697 1697 .rx_fixup = ax88179_rx_fixup, 1698 1698 .tx_fixup = ax88179_tx_fixup, 1699 1699 }; ··· 1706 1706 .link_reset = ax88179_link_reset, 1707 1707 .reset = ax88179_reset, 1708 1708 .stop = ax88179_stop, 1709 - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, 1709 + .flags = FLAG_ETHER | FLAG_FRAMING_AX, 1710 1710 .rx_fixup = ax88179_rx_fixup, 1711 1711 .tx_fixup = ax88179_tx_fixup, 1712 1712 }; ··· 1719 1719 .link_reset = ax88179_link_reset, 1720 1720 .reset = ax88179_reset, 1721 1721 .stop = ax88179_stop, 1722 - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, 1722 + .flags = FLAG_ETHER | FLAG_FRAMING_AX, 1723 1723 .rx_fixup = ax88179_rx_fixup, 1724 1724 .tx_fixup = ax88179_tx_fixup, 1725 1725 }; ··· 1732 1732 .link_reset = ax88179_link_reset, 1733 1733 .reset = ax88179_reset, 1734 1734 .stop = ax88179_stop, 1735 - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, 1735 + .flags = FLAG_ETHER | FLAG_FRAMING_AX, 1736 1736 .rx_fixup = ax88179_rx_fixup, 1737 1737 .tx_fixup = ax88179_tx_fixup, 1738 1738 }; ··· 1745 1745 .link_reset = ax88179_link_reset, 1746 1746 .reset = ax88179_reset, 1747 1747 .stop = ax88179_stop, 1748 - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, 1748 + .flags = FLAG_ETHER | FLAG_FRAMING_AX, 1749 1749 .rx_fixup = ax88179_rx_fixup, 1750 1750 .tx_fixup = ax88179_tx_fixup, 1751 1751 }; ··· 1758 1758 .link_reset = ax88179_link_reset, 1759 1759 .reset = ax88179_reset, 1760 1760 .stop = ax88179_stop, 1761 - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, 1761 + .flags = FLAG_ETHER | FLAG_FRAMING_AX, 1762 1762 .rx_fixup = ax88179_rx_fixup, 1763 1763 .tx_fixup = ax88179_tx_fixup, 1764 1764 }; ··· 1771 1771 .link_reset = ax88179_link_reset, 1772 1772 .reset = ax88179_reset, 1773 1773 .stop = ax88179_stop, 1774 - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, 1774 + .flags = FLAG_ETHER | FLAG_FRAMING_AX, 1775 1775 .rx_fixup = ax88179_rx_fixup, 1776 1776 .tx_fixup = ax88179_tx_fixup, 1777 1777 }; ··· 1784 1784 .link_reset = ax88179_link_reset, 1785 1785 .reset = ax88179_reset, 1786 1786 .stop = ax88179_stop, 1787 - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, 1787 + .flags = FLAG_ETHER | FLAG_FRAMING_AX, 1788 1788 .rx_fixup = ax88179_rx_fixup, 1789 1789 .tx_fixup = ax88179_tx_fixup, 1790 1790 }; ··· 1797 1797 .link_reset = ax88179_link_reset, 1798 1798 .reset = ax88179_reset, 1799 1799 .stop = ax88179_stop, 1800 - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, 1800 + .flags = FLAG_ETHER | FLAG_FRAMING_AX, 1801 1801 .rx_fixup = ax88179_rx_fixup, 1802 1802 .tx_fixup = ax88179_tx_fixup, 1803 1803 }; ··· 1810 1810 .link_reset = ax88179_link_reset, 1811 1811 .reset = ax88179_reset, 1812 1812 .stop = ax88179_stop, 1813 - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, 1813 + .flags = FLAG_ETHER | FLAG_FRAMING_AX, 1814 1814 .rx_fixup = ax88179_rx_fixup, 1815 1815 .tx_fixup = ax88179_tx_fixup, 1816 1816 }; ··· 1823 1823 .link_reset = ax88179_link_reset, 1824 1824 .reset = ax88179_reset, 1825 1825 .stop = ax88179_stop, 1826 - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, 1826 + .flags = FLAG_ETHER | FLAG_FRAMING_AX, 1827 1827 .rx_fixup = ax88179_rx_fixup, 1828 1828 .tx_fixup = ax88179_tx_fixup, 1829 1829 }; ··· 1836 1836 .link_reset = ax88179_link_reset, 1837 1837 .reset = ax88179_reset, 1838 1838 .stop = ax88179_stop, 1839 - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, 1839 + .flags = FLAG_ETHER | FLAG_FRAMING_AX, 1840 1840 .rx_fixup = ax88179_rx_fixup, 1841 1841 .tx_fixup = ax88179_tx_fixup, 1842 1842 };