Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

tile: fix some -Wsign-compare warnings

Normally the build doesn't include these warnings, but at one
point I built with -Wsign-compare, and noticed a few things that
are technically bugs. This change fixes those things.

Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>

+6 -6
+3 -3
arch/tile/include/asm/io.h
··· 255 255 256 256 static inline void memset_io(volatile void *dst, int val, size_t len) 257 257 { 258 - int x; 258 + size_t x; 259 259 BUG_ON((unsigned long)dst & 0x3); 260 260 val = (val & 0xff) * 0x01010101; 261 261 for (x = 0; x < len; x += 4) ··· 265 265 static inline void memcpy_fromio(void *dst, const volatile void __iomem *src, 266 266 size_t len) 267 267 { 268 - int x; 268 + size_t x; 269 269 BUG_ON((unsigned long)src & 0x3); 270 270 for (x = 0; x < len; x += 4) 271 271 *(u32 *)(dst + x) = readl(src + x); ··· 274 274 static inline void memcpy_toio(volatile void __iomem *dst, const void *src, 275 275 size_t len) 276 276 { 277 - int x; 277 + size_t x; 278 278 BUG_ON((unsigned long)dst & 0x3); 279 279 for (x = 0; x < len; x += 4) 280 280 writel(*(u32 *)(src + x), dst + x);
+1 -1
arch/tile/include/asm/mmzone.h
··· 42 42 43 43 #define kern_addr_valid(kaddr) virt_addr_valid((void *)kaddr) 44 44 45 - static inline int pfn_valid(int pfn) 45 + static inline int pfn_valid(unsigned long pfn) 46 46 { 47 47 int nid = pfn_to_nid(pfn); 48 48
+2 -2
arch/tile/include/asm/spinlock_64.h
··· 27 27 * Return the "current" portion of a ticket lock value, 28 28 * i.e. the number that currently owns the lock. 29 29 */ 30 - static inline int arch_spin_current(u32 val) 30 + static inline u32 arch_spin_current(u32 val) 31 31 { 32 32 return val >> __ARCH_SPIN_CURRENT_SHIFT; 33 33 } ··· 36 36 * Return the "next" portion of a ticket lock value, 37 37 * i.e. the number that the next task to try to acquire the lock will get. 38 38 */ 39 - static inline int arch_spin_next(u32 val) 39 + static inline u32 arch_spin_next(u32 val) 40 40 { 41 41 return val & __ARCH_SPIN_NEXT_MASK; 42 42 }