Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

whack-a-mole: don't open-code iminor/imajor

several instances creeped back into the tree...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Al Viro 6f24784f 9652c732

+15 -17
+2 -4
arch/sh/boards/mach-landisk/gio.c
··· 27 27 28 28 static int gio_open(struct inode *inode, struct file *filp) 29 29 { 30 - int minor; 30 + int minor = iminor(inode); 31 31 int ret = -ENOENT; 32 32 33 33 preempt_disable(); 34 - minor = MINOR(inode->i_rdev); 35 34 if (minor < DEVCOUNT) { 36 35 if (openCnt > 0) { 37 36 ret = -EALREADY; ··· 45 46 46 47 static int gio_close(struct inode *inode, struct file *filp) 47 48 { 48 - int minor; 49 + int minor = iminor(inode); 49 50 50 - minor = MINOR(inode->i_rdev); 51 51 if (minor < DEVCOUNT) { 52 52 openCnt--; 53 53 }
+1 -1
drivers/block/loop.c
··· 663 663 { 664 664 struct inode *i = file->f_mapping->host; 665 665 666 - return i && S_ISBLK(i->i_mode) && MAJOR(i->i_rdev) == LOOP_MAJOR; 666 + return i && S_ISBLK(i->i_mode) && imajor(i) == LOOP_MAJOR; 667 667 } 668 668 669 669 static int loop_validate_file(struct file *file, struct block_device *bdev)
+1 -1
drivers/dax/super.c
··· 480 480 kfree(dax_dev->host); 481 481 dax_dev->host = NULL; 482 482 if (inode->i_rdev) 483 - ida_simple_remove(&dax_minor_ida, MINOR(inode->i_rdev)); 483 + ida_simple_remove(&dax_minor_ida, iminor(inode)); 484 484 kmem_cache_free(dax_cache, dax_dev); 485 485 } 486 486
+2 -2
drivers/rtc/rtc-m41t80.c
··· 783 783 */ 784 784 static int wdt_open(struct inode *inode, struct file *file) 785 785 { 786 - if (MINOR(inode->i_rdev) == WATCHDOG_MINOR) { 786 + if (iminor(inode) == WATCHDOG_MINOR) { 787 787 mutex_lock(&m41t80_rtc_mutex); 788 788 if (test_and_set_bit(0, &wdt_is_open)) { 789 789 mutex_unlock(&m41t80_rtc_mutex); ··· 807 807 */ 808 808 static int wdt_release(struct inode *inode, struct file *file) 809 809 { 810 - if (MINOR(inode->i_rdev) == WATCHDOG_MINOR) 810 + if (iminor(inode) == WATCHDOG_MINOR) 811 811 clear_bit(0, &wdt_is_open); 812 812 return 0; 813 813 }
+1 -1
drivers/s390/char/vmur.c
··· 681 681 * We treat the minor number as the devno of the ur device 682 682 * to find in the driver tree. 683 683 */ 684 - devno = MINOR(file_inode(file)->i_rdev); 684 + devno = iminor(file_inode(file)); 685 685 686 686 urd = urdev_get_from_devno(devno); 687 687 if (!urd) {
+6 -6
drivers/staging/vme/devices/vme_user.c
··· 175 175 static ssize_t vme_user_read(struct file *file, char __user *buf, size_t count, 176 176 loff_t *ppos) 177 177 { 178 - unsigned int minor = MINOR(file_inode(file)->i_rdev); 178 + unsigned int minor = iminor(file_inode(file)); 179 179 ssize_t retval; 180 180 size_t image_size; 181 181 ··· 218 218 static ssize_t vme_user_write(struct file *file, const char __user *buf, 219 219 size_t count, loff_t *ppos) 220 220 { 221 - unsigned int minor = MINOR(file_inode(file)->i_rdev); 221 + unsigned int minor = iminor(file_inode(file)); 222 222 ssize_t retval; 223 223 size_t image_size; 224 224 ··· 260 260 261 261 static loff_t vme_user_llseek(struct file *file, loff_t off, int whence) 262 262 { 263 - unsigned int minor = MINOR(file_inode(file)->i_rdev); 263 + unsigned int minor = iminor(file_inode(file)); 264 264 size_t image_size; 265 265 loff_t res; 266 266 ··· 294 294 struct vme_slave slave; 295 295 struct vme_irq_id irq_req; 296 296 unsigned long copied; 297 - unsigned int minor = MINOR(inode->i_rdev); 297 + unsigned int minor = iminor(inode); 298 298 int retval; 299 299 dma_addr_t pci_addr; 300 300 void __user *argp = (void __user *)arg; ··· 412 412 { 413 413 int ret; 414 414 struct inode *inode = file_inode(file); 415 - unsigned int minor = MINOR(inode->i_rdev); 415 + unsigned int minor = iminor(inode); 416 416 417 417 mutex_lock(&image[minor].mutex); 418 418 ret = vme_user_ioctl(inode, file, cmd, arg); ··· 481 481 482 482 static int vme_user_mmap(struct file *file, struct vm_area_struct *vma) 483 483 { 484 - unsigned int minor = MINOR(file_inode(file)->i_rdev); 484 + unsigned int minor = iminor(file_inode(file)); 485 485 486 486 if (type[minor] == MASTER_MINOR) 487 487 return vme_user_master_mmap(minor, vma);
+2 -2
fs/gfs2/inode.c
··· 490 490 di = (struct gfs2_dinode *)dibh->b_data; 491 491 gfs2_dinode_out(ip, di); 492 492 493 - di->di_major = cpu_to_be32(MAJOR(ip->i_inode.i_rdev)); 494 - di->di_minor = cpu_to_be32(MINOR(ip->i_inode.i_rdev)); 493 + di->di_major = cpu_to_be32(imajor(&ip->i_inode)); 494 + di->di_minor = cpu_to_be32(iminor(&ip->i_inode)); 495 495 di->__pad1 = 0; 496 496 di->__pad2 = 0; 497 497 di->__pad3 = 0;