Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

carl9170: fix debugfs crashes

Ben Greear reported:
> I see lots of instability as soon as I load up the carl9710 NIC.
> My application is going to be poking at it's debugfs files...
>
> BUG: KASAN: slab-out-of-bounds in carl9170_debugfs_read+0xd5/0x2a0
> [carl9170] at addr 0xffff8801bc1208b0
> Read of size 8 by task btserver/5888
> =======================================================================
> BUG kmalloc-256 (Tainted: G W ): kasan: bad access detected
> -----------------------------------------------------------------------
>
> INFO: Allocated in seq_open+0x50/0x100 age=2690 cpu=2 pid=772
>...

This breakage was caused by the introduction of intermediate
fops in debugfs by commit 9fd4dcece43a
("debugfs: prevent access to possibly dead file_operations at file open")

Thankfully, the original/real fops are still available in d_fsdata.

Reported-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
Cc: stable <stable@vger.kernel.org> # 4.7+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Christian Lamparter and committed by
Greg Kroah-Hartman
6ee6d1cb 9c4a45b1

+4 -2
+4 -2
drivers/net/wireless/ath/carl9170/debug.c
··· 75 75 76 76 if (!ar) 77 77 return -ENODEV; 78 - dfops = container_of(file->f_op, struct carl9170_debugfs_fops, fops); 78 + dfops = container_of(debugfs_real_fops(file), 79 + struct carl9170_debugfs_fops, fops); 79 80 80 81 if (!dfops->read) 81 82 return -ENOSYS; ··· 128 127 129 128 if (!ar) 130 129 return -ENODEV; 131 - dfops = container_of(file->f_op, struct carl9170_debugfs_fops, fops); 130 + dfops = container_of(debugfs_real_fops(file), 131 + struct carl9170_debugfs_fops, fops); 132 132 133 133 if (!dfops->write) 134 134 return -ENOSYS;