Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

crypto: cavium - cpt_bind_vq_to_grp could return an error code

cpt_bind_vq_to_grp() could return an error code. However, it currently
returns a u8. This produce the static checker warning.

drivers/crypto/cavium/cpt/cptpf_mbox.c:70 cpt_bind_vq_to_grp() warn: signedness bug returning '(-22)'

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: George Cherian <george.cherian@cavium.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

George Cherian and committed by
Herbert Xu
6ecb7d62 36b05efc

+2 -2
+2 -2
drivers/crypto/cavium/cpt/cptpf_mbox.c
··· 59 59 cpt_write_csr64(cpt->reg_base, CPTX_PF_QX_CTL(0, vf), pf_qx_ctl.u); 60 60 } 61 61 62 - static u8 cpt_bind_vq_to_grp(struct cpt_device *cpt, u8 q, u8 grp) 62 + static int cpt_bind_vq_to_grp(struct cpt_device *cpt, u8 q, u8 grp) 63 63 { 64 64 struct microcode *mcode = cpt->mcode; 65 65 union cptx_pf_qx_ctl pf_qx_ctl; ··· 90 90 { 91 91 struct cpt_vf_info *vfx = &cpt->vfinfo[vf]; 92 92 struct cpt_mbox mbx = {}; 93 - u8 vftype; 93 + int vftype; 94 94 struct device *dev = &cpt->pdev->dev; 95 95 /* 96 96 * MBOX[0] contains msg