Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fpga: fix potential null pointer deref in fpga_mgr_test_img_load_sgt()

fpga_mgr_test_img_load_sgt() allocates memory for sgt using
kunit_kzalloc() however it does not check if the allocation failed.
It then passes sgt to sg_alloc_table(), which passes it to
__sg_alloc_table(). This function calls memset() on sgt in an attempt to
zero it out. If the allocation fails then sgt will be NULL and the
memset will trigger a NULL pointer dereference.

Fix this by checking the allocation with KUNIT_ASSERT_NOT_ERR_OR_NULL().

Reviewed-by: Marco Pagani <marco.pagani@linux.dev>
Fixes: ccbc1c302115 ("fpga: add an initial KUnit suite for the FPGA Manager")
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20250422153737.5264-1-qasdev00@gmail.com
Signed-off-by: Xu Yilun <yilun.xu@linux.intel.com>

authored by

Qasim Ijaz and committed by
Xu Yilun
6ebf1982 99b11851

+1
+1
drivers/fpga/tests/fpga-mgr-test.c
··· 263 263 img_buf = init_test_buffer(test, IMAGE_SIZE); 264 264 265 265 sgt = kunit_kzalloc(test, sizeof(*sgt), GFP_KERNEL); 266 + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, sgt); 266 267 ret = sg_alloc_table(sgt, 1, GFP_KERNEL); 267 268 KUNIT_ASSERT_EQ(test, ret, 0); 268 269 sg_init_one(sgt->sgl, img_buf, IMAGE_SIZE);