Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests: mptcp: netlink: drop disable=SC2086

Now there are only a few of variables are not using double quotes.
Modifying them, then "shellcheck disable=SC2086" can be dropped.

Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Geliang Tang and committed by
David S. Miller
6eaeda12 0cef6fca

+3 -8
+3 -8
tools/testing/selftests/net/mptcp/pm_netlink.sh
··· 1 1 #!/bin/bash 2 2 # SPDX-License-Identifier: GPL-2.0 3 3 4 - # Double quotes to prevent globbing and word splitting is recommended in new 5 - # code but we accept it, especially because there were too many before having 6 - # address all other issues detected by shellcheck. 7 - #shellcheck disable=SC2086 8 - 9 4 . "$(dirname "${0}")/mptcp_lib.sh" 10 5 11 6 ret=0 ··· 15 20 while getopts "$optstring" option;do 16 21 case "$option" in 17 22 "h") 18 - usage $0 23 + usage "$0" 19 24 exit ${KSFT_PASS} 20 25 ;; 21 26 "i") 22 27 mptcp_lib_set_ip_mptcp 23 28 ;; 24 29 "?") 25 - usage $0 30 + usage "$0" 26 31 exit ${KSFT_FAIL} 27 32 ;; 28 33 esac ··· 35 40 #shellcheck disable=SC2317 36 41 cleanup() 37 42 { 38 - rm -f $err 43 + rm -f "${err}" 39 44 mptcp_lib_ns_exit "${ns1}" 40 45 } 41 46