Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pas16: don't call free_dma()

The pas16 scsi driver does not use DMA, and the call to free_dma()
in its exit function seems to have been copied incorrectly from
another driver but never caused trouble.

One case where it gets in the way is randconfig builds on ARM,
which depending on the configuration does not provide a free_dma()
function, causing this build error:

drivers/scsi/pas16.c: In function 'pas16_release':
drivers/scsi/pas16.c:611:3: error: implicit declaration of function 'free_dma' [-Werror=implicit-function-declaration]
free_dma(shost->dma_channel);

Removing the incorrect function calls should be the obvious
fix for this, with no downsides.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Christoph Hellwig <hch@lst.de>

authored by

Arnd Bergmann and committed by
Christoph Hellwig
6ea8631d c86d1ae2

-2
-2
drivers/scsi/pas16.c
··· 607 607 if (shost->irq) 608 608 free_irq(shost->irq, shost); 609 609 NCR5380_exit(shost); 610 - if (shost->dma_channel != 0xff) 611 - free_dma(shost->dma_channel); 612 610 if (shost->io_port && shost->n_io_port) 613 611 release_region(shost->io_port, shost->n_io_port); 614 612 scsi_unregister(shost);