Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev: matrox: fix -Wextra build warnings

When 'DEBUG' is not defined, modify the dprintk() macro to use the
no_printk() macro instead of using <empty>.
This fixes build warnings when -Wextra is used and provides
printk format checking:

../drivers/video/fbdev/matrox/matroxfb_base.c:635:77: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
../drivers/video/fbdev/matrox/matroxfb_Ti3026.c:632:54: warning: suggest braces around empty body in an ‘else’ statement [-Wempty-body]
../drivers/video/fbdev/matrox/matroxfb_Ti3026.c:654:53: warning: suggest braces around empty body in an ‘else’ statement [-Wempty-body]

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Antonino Daplas <adaplas@gmail.com>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200315041002.24473-4-rdunlap@infradead.org

authored by

Randy Dunlap and committed by
Bartlomiej Zolnierkiewicz
6ea16a0b c43da061

+1 -1
+1 -1
drivers/video/fbdev/matrox/matroxfb_base.h
··· 86 86 #ifdef DEBUG 87 87 #define dprintk(X...) printk(X) 88 88 #else 89 - #define dprintk(X...) 89 + #define dprintk(X...) no_printk(X) 90 90 #endif 91 91 92 92 #ifndef PCI_SS_VENDOR_ID_SIEMENS_NIXDORF