Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwmon: (acpi_power_meter) Change log level for 'unsafe software power cap'

At boot time, the acpi_power_meter driver logs the following error level
message: "Ignoring unsafe software power cap". Having read about it from
a few sources, it seems that the error message can be quite misleading.

While the message can imply that Linux is ignoring the fact that the
system is operating in potentially dangerous conditions, the truth is
the driver found an ACPI_PMC object that supports software power
capping. The driver simply decides not to use it, perhaps because it
doesn't support the object.

The best solution is probably changing the log level from error to warning.
All sources I have found, regarding the error, have downplayed its
significance. There is not much of a reason for it to be on error level,
while causing potential confusions or misinterpretations.

Signed-off-by: Wang Shenran <shenran268@gmail.com>
Link: https://lore.kernel.org/r/20190724080110.6952-1-shenran268@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

authored by

Wang Shenran and committed by
Guenter Roeck
6e4d91aa 29c7cb48

+2 -2
+2 -2
drivers/hwmon/acpi_power_meter.c
··· 681 681 682 682 if (resource->caps.flags & POWER_METER_CAN_CAP) { 683 683 if (!can_cap_in_hardware()) { 684 - dev_err(&resource->acpi_dev->dev, 685 - "Ignoring unsafe software power cap!\n"); 684 + dev_warn(&resource->acpi_dev->dev, 685 + "Ignoring unsafe software power cap!\n"); 686 686 goto skip_unsafe_cap; 687 687 } 688 688