Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers/net/skfp: fix sparse warning: Should it be static?

Impact: Move function declarations to header file.

Fix this sparse warnings:
drivers/net/skfp/cfm.c:146:6: warning: symbol 'all_selection_criteria' was not declared. Should it be static?
drivers/net/skfp/drvfbi.c:186:6: warning: symbol 'mac1_irq' was not declared. Should it be static?
drivers/net/skfp/drvfbi.c:284:6: warning: symbol 'read_address' was not declared. Should it be static?
drivers/net/skfp/drvfbi.c:323:6: warning: symbol 'init_board' was not declared. Should it be static?
drivers/net/skfp/fplustm.c:72:24: warning: symbol 'fddi_broadcast' was not declared. Should it be static?
drivers/net/skfp/fplustm.c:679:6: warning: symbol 'mac2_irq' was not declared. Should it be static?
drivers/net/skfp/fplustm.c:805:6: warning: symbol 'mac3_irq' was not declared. Should it be static?
drivers/net/skfp/fplustm.c:856:5: warning: symbol 'init_fplus' was not declared. Should it be static?
drivers/net/skfp/pcmplc.c:404:6: warning: symbol 'init_plc' was not declared. Should it be static?
drivers/net/skfp/pcmplc.c:1592:5: warning: symbol 'pcm_status_twisted' was not declared. Should it be static?
drivers/net/skfp/smtinit.c:68:5: warning: symbol 'init_smt' was not declared. Should it be static?

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Hannes Eder and committed by
David S. Miller
6e470d26 37d37695

+17 -25
+17
drivers/net/skfp/h/smc.h
··· 467 467 #endif /* DEBUG_BRD && DEBUG */ 468 468 } ; 469 469 470 + extern const struct fddi_addr fddi_broadcast; 471 + 472 + extern void all_selection_criteria(struct s_smc *smc); 473 + extern void card_stop(struct s_smc *smc); 474 + extern void init_board(struct s_smc *smc, u_char *mac_addr); 475 + extern int init_fplus(struct s_smc *smc); 476 + extern void init_plc(struct s_smc *smc); 477 + extern int init_smt(struct s_smc *smc, u_char * mac_addr); 478 + extern void mac1_irq(struct s_smc *smc, u_short stu, u_short stl); 479 + extern void mac2_irq(struct s_smc *smc, u_short code_s2u, u_short code_s2l); 480 + extern void mac3_irq(struct s_smc *smc, u_short code_s3u, u_short code_s3l); 481 + extern int pcm_status_twisted(struct s_smc *smc); 482 + extern void plc1_irq(struct s_smc *smc); 483 + extern void plc2_irq(struct s_smc *smc); 484 + extern void read_address(struct s_smc *smc, u_char * mac_addr); 485 + extern void timer_irq(struct s_smc *smc); 486 + 470 487 #endif /* _SCMECM_ */ 471 488
-9
drivers/net/skfp/hwmtm.c
··· 97 97 98 98 extern void* mac_drv_get_space(struct s_smc *smc, unsigned int size); 99 99 extern void* mac_drv_get_desc_mem(struct s_smc *smc, unsigned int size); 100 - extern void init_board(struct s_smc *smc, u_char *mac_addr); 101 100 extern void mac_drv_fill_rxd(struct s_smc *smc); 102 - extern void plc1_irq(struct s_smc *smc); 103 101 extern void mac_drv_tx_complete(struct s_smc *smc, 104 102 volatile struct s_smt_fp_txd *txd); 105 - extern void plc2_irq(struct s_smc *smc); 106 - extern void mac1_irq(struct s_smc *smc, u_short stu, u_short stl); 107 - extern void mac2_irq(struct s_smc *smc, u_short code_s2u, u_short code_s2l); 108 - extern void mac3_irq(struct s_smc *smc, u_short code_s3u, u_short code_s3l); 109 - extern void timer_irq(struct s_smc *smc); 110 103 extern void mac_drv_rx_complete(struct s_smc *smc, 111 104 volatile struct s_smt_fp_rxd *rxd, 112 105 int frag_count, int len); 113 106 extern void mac_drv_requeue_rxd(struct s_smc *smc, 114 107 volatile struct s_smt_fp_rxd *rxd, 115 108 int frag_count); 116 - extern void init_plc(struct s_smc *smc); 117 109 extern void mac_drv_clear_rxd(struct s_smc *smc, 118 110 volatile struct s_smt_fp_rxd *rxd, int frag_count); 119 111 ··· 128 136 int flag); 129 137 #endif 130 138 131 - extern int init_fplus(struct s_smc *smc); 132 139 extern int mac_drv_rx_init(struct s_smc *smc, int len, int fc, char *look_ahead, 133 140 int la_len); 134 141
-3
drivers/net/skfp/pcmplc.c
··· 198 198 static const int plc_imsk_act = PL_PCM_CODE | PL_TRACE_PROP | PL_PCM_BREAK | 199 199 PL_PCM_ENABLED | PL_SELF_TEST | PL_EBUF_ERR; 200 200 201 - /* external functions */ 202 - void all_selection_criteria(struct s_smc *smc); 203 - 204 201 /* internal functions */ 205 202 static void pcm_fsm(struct s_smc *smc, struct s_phy *phy, int cmd); 206 203 static void pc_rcode_actions(struct s_smc *smc, int bit, struct s_phy *phy);
-3
drivers/net/skfp/skfddi.c
··· 135 135 136 136 // External functions from the hardware module 137 137 extern u_int mac_drv_check_space(void); 138 - extern void read_address(struct s_smc *smc, u_char * mac_addr); 139 - extern void card_stop(struct s_smc *smc); 140 138 extern int mac_drv_init(struct s_smc *smc); 141 139 extern void hwm_tx_frag(struct s_smc *smc, char far * virt, u_long phys, 142 140 int len, int frame_status); 143 141 extern int hwm_tx_init(struct s_smc *smc, u_char fc, int frag_count, 144 142 int frame_len, int frame_status); 145 - extern int init_smt(struct s_smc *smc, u_char * mac_addr); 146 143 extern void fddi_isr(struct s_smc *smc); 147 144 extern void hwm_rx_frag(struct s_smc *smc, char far * virt, u_long phys, 148 145 int len, int frame_status);
-10
drivers/net/skfp/smt.c
··· 55 55 } ; 56 56 57 57 /* 58 - * external variables 59 - */ 60 - extern const struct fddi_addr fddi_broadcast ; 61 - 62 - /* 63 - * external functions 64 - */ 65 - int pcm_status_twisted(struct s_smc *smc); 66 - 67 - /* 68 58 * function prototypes 69 59 */ 70 60 #ifdef LITTLE_ENDIAN