Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpu: host1x: Fix a couple of checkpatch warnings

Fix a couple of occurrences where no blank line was used to separate
variable declarations from code or where block comments were wrongly
formatted.

Signed-off-by: Thierry Reding <treding@nvidia.com>

+24 -8
+6 -2
drivers/gpu/host1x/cdma.c
··· 247 247 /* Pop push buffer slots */ 248 248 if (job->num_slots) { 249 249 struct push_buffer *pb = &cdma->push_buffer; 250 + 250 251 host1x_pushbuffer_pop(pb, job->num_slots); 251 252 if (cdma->event == CDMA_EVENT_PUSH_BUFFER_SPACE) 252 253 signal = true; ··· 343 342 syncpt_val += syncpt_incrs; 344 343 } 345 344 346 - /* The following sumbits from the same client may be dependent on the 345 + /* 346 + * The following sumbits from the same client may be dependent on the 347 347 * failed submit and therefore they may fail. Force a small timeout 348 - * to make the queue cleanup faster */ 348 + * to make the queue cleanup faster. 349 + */ 349 350 350 351 list_for_each_entry_from(job, &cdma->sync_queue, list) 351 352 if (job->client == cdma->timeout.client) ··· 413 410 /* init state on first submit with timeout value */ 414 411 if (!cdma->timeout.initialized) { 415 412 int err; 413 + 416 414 err = host1x_hw_cdma_timeout_init(host1x, cdma, 417 415 job->syncpt_id); 418 416 if (err) {
+3
drivers/gpu/host1x/debug.c
··· 63 63 static void show_syncpts(struct host1x *m, struct output *o) 64 64 { 65 65 unsigned int i; 66 + 66 67 host1x_debug_output(o, "---- syncpts ----\n"); 67 68 for (i = 0; i < host1x_syncpt_nb_pts(m); i++) { 68 69 u32 max = host1x_syncpt_read_max(m->syncpt + i); 69 70 u32 min = host1x_syncpt_load(m->syncpt + i); 71 + 70 72 if (!min && !max) 71 73 continue; 72 74 ··· 78 76 79 77 for (i = 0; i < host1x_syncpt_nb_bases(m); i++) { 80 78 u32 base_val; 79 + 81 80 base_val = host1x_syncpt_load_wait_base(m->syncpt + i); 82 81 if (base_val) 83 82 host1x_debug_output(o, "waitbase id %u val %d\n", i,
+1 -1
drivers/gpu/host1x/dev.c
··· 102 102 .dma_mask = DMA_BIT_MASK(34), 103 103 }; 104 104 105 - static struct of_device_id host1x_of_match[] = { 105 + static const struct of_device_id host1x_of_match[] = { 106 106 { .compatible = "nvidia,tegra210-host1x", .data = &host1x05_info, }, 107 107 { .compatible = "nvidia,tegra124-host1x", .data = &host1x04_info, }, 108 108 { .compatible = "nvidia,tegra114-host1x", .data = &host1x02_info, },
+3 -4
drivers/gpu/host1x/hw/debug_hw.c
··· 51 51 val >> 6 & 0x3ff, 52 52 val >> 16 & 0xfff, mask); 53 53 return hweight8(mask); 54 - } else { 55 - host1x_debug_output(o, "SETCL(class=%03x)\n", 56 - val >> 6 & 0x3ff); 57 - return 0; 58 54 } 55 + 56 + host1x_debug_output(o, "SETCL(class=%03x)\n", val >> 6 & 0x3ff); 57 + return 0; 59 58 60 59 case HOST1X_OPCODE_INCR: 61 60 host1x_debug_output(o, "INCR(offset=%03x, [",
+2
drivers/gpu/host1x/hw/syncpt_hw.c
··· 38 38 static void syncpt_restore_wait_base(struct host1x_syncpt *sp) 39 39 { 40 40 struct host1x *host = sp->host; 41 + 41 42 host1x_sync_writel(host, sp->base_val, 42 43 HOST1X_SYNC_SYNCPT_BASE(sp->id)); 43 44 } ··· 49 48 static void syncpt_read_wait_base(struct host1x_syncpt *sp) 50 49 { 51 50 struct host1x *host = sp->host; 51 + 52 52 sp->base_val = 53 53 host1x_sync_readl(host, HOST1X_SYNC_SYNCPT_BASE(sp->id)); 54 54 }
+2
drivers/gpu/host1x/intr.c
··· 122 122 static void action_wakeup(struct host1x_waitlist *waiter) 123 123 { 124 124 wait_queue_head_t *wq = waiter->data; 125 + 125 126 wake_up(wq); 126 127 } 127 128 128 129 static void action_wakeup_interruptible(struct host1x_waitlist *waiter) 129 130 { 130 131 wait_queue_head_t *wq = waiter->data; 132 + 131 133 wake_up_interruptible(wq); 132 134 } 133 135
+3
drivers/gpu/host1x/job.c
··· 464 464 465 465 for (i = 0; i < job->num_gathers; i++) { 466 466 struct host1x_job_gather *g = &job->gathers[i]; 467 + 467 468 size += g->words * sizeof(u32); 468 469 } 469 470 ··· 515 514 bitmap_zero(waitchk_mask, host1x_syncpt_nb_pts(host)); 516 515 for (i = 0; i < job->num_waitchk; i++) { 517 516 u32 syncpt_id = job->waitchk[i].syncpt_id; 517 + 518 518 if (syncpt_id < host1x_syncpt_nb_pts(host)) 519 519 set_bit(syncpt_id, waitchk_mask); 520 520 } ··· 573 571 574 572 for (i = 0; i < job->num_unpins; i++) { 575 573 struct host1x_job_unpin_data *unpin = &job->unpins[i]; 574 + 576 575 host1x_bo_unpin(unpin->bo, unpin->sgt); 577 576 host1x_bo_put(unpin->bo); 578 577 }
+4 -1
drivers/gpu/host1x/syncpt.c
··· 146 146 u32 host1x_syncpt_load(struct host1x_syncpt *sp) 147 147 { 148 148 u32 val; 149 + 149 150 val = host1x_hw_syncpt_load(sp->host, sp); 150 151 trace_host1x_syncpt_load_min(sp->id, val); 151 152 ··· 159 158 u32 host1x_syncpt_load_wait_base(struct host1x_syncpt *sp) 160 159 { 161 160 u32 val; 161 + 162 162 host1x_hw_syncpt_load_wait_base(sp->host, sp); 163 163 val = sp->base_val; 164 164 return val; ··· 281 279 { 282 280 u32 current_val; 283 281 u32 future_val; 282 + 284 283 smp_rmb(); 285 284 current_val = (u32)atomic_read(&sp->min_val); 286 285 future_val = (u32)atomic_read(&sp->max_val); ··· 411 408 /* 412 409 * Read max. It indicates how many operations there are in queue, either in 413 410 * channel or in a software thread. 414 - * */ 411 + */ 415 412 u32 host1x_syncpt_read_max(struct host1x_syncpt *sp) 416 413 { 417 414 smp_rmb();