Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

HID: cp2112: fix to force single data-report reply

Current implementation of cp2112_raw_event() only accepts one data report at a
time. If last received data report is not fully handled yet, a new incoming
data report will overwrite it. In such case we don't guaranteed to propagate
the correct incoming data.

The trivial fix implemented here forces a single report at a time by requesting
in cp2112_read() no more than 61 byte of data, which is the payload size of a
single data report.

Cc: stable@vger.kernel.org
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Tested-by: Ellen Wang <ellen@cumulusnetworks.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>

authored by

Antonio Borneo and committed by
Jiri Kosina
6debce6f 9633920e

+2
+2
drivers/hid/hid-cp2112.c
··· 356 356 struct cp2112_force_read_report report; 357 357 int ret; 358 358 359 + if (size > sizeof(dev->read_data)) 360 + size = sizeof(dev->read_data); 359 361 report.report = CP2112_DATA_READ_FORCE_SEND; 360 362 report.length = cpu_to_be16(size); 361 363