Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: bcmasp: fix early exit leak with fixed phy

We are not deregistering the fixed phy link when hitting the early
exit condition. Add the correct early exit sequence.

Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
Signed-off-by: Justin Chen <justin.chen@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20260122194001.1098859-1-justin.chen@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Justin Chen and committed by
Jakub Kicinski
6de4436b d48c896c

+4 -1
+4 -1
drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
··· 1261 1261 netdev_err(intf->ndev, "invalid PHY mode: %s for port %d\n", 1262 1262 phy_modes(intf->phy_interface), intf->port); 1263 1263 ret = -EINVAL; 1264 - goto err_free_netdev; 1264 + goto err_deregister_fixed_link; 1265 1265 } 1266 1266 1267 1267 ret = of_get_ethdev_address(ndev_dn, ndev); ··· 1286 1286 1287 1287 return intf; 1288 1288 1289 + err_deregister_fixed_link: 1290 + if (of_phy_is_fixed_link(ndev_dn)) 1291 + of_phy_deregister_fixed_link(ndev_dn); 1289 1292 err_free_netdev: 1290 1293 free_netdev(ndev); 1291 1294 err: