Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

s390/qeth: remove check for packing mode in qeth_check_outbound_queue()

If qeth_check_outbound_queue() finds a partially filled TX buffer on
the queue and flushes it, then the queue _must_ have been in packing
mode.

Remove the redundant check when updating the relevant statistics.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Julian Wiedmann and committed by
Jakub Kicinski
6dc490e8 1b9e410f

+1 -4
+1 -4
drivers/s390/net/qeth_core_main.c
··· 3635 3635 if ((atomic_read(&queue->used_buffers) <= QETH_LOW_WATERMARK_PACK) || 3636 3636 !atomic_read(&queue->set_pci_flags_count)) { 3637 3637 unsigned int index, flush_cnt; 3638 - bool q_was_packing; 3639 3638 3640 3639 spin_lock(&queue->lock); 3641 3640 3642 3641 index = queue->next_buf_to_fill; 3643 - q_was_packing = queue->do_pack; 3644 3642 3645 3643 flush_cnt = qeth_switch_to_nonpacking_if_needed(queue); 3646 3644 if (!flush_cnt && !atomic_read(&queue->set_pci_flags_count)) ··· 3646 3648 3647 3649 if (flush_cnt) { 3648 3650 qeth_flush_buffers(queue, index, flush_cnt); 3649 - if (q_was_packing) 3650 - QETH_TXQ_STAT_ADD(queue, bufs_pack, flush_cnt); 3651 + QETH_TXQ_STAT_ADD(queue, bufs_pack, flush_cnt); 3651 3652 } 3652 3653 3653 3654 spin_unlock(&queue->lock);