Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: dsa: loop: Do not unregister invalid fixed PHY

During error injection it was possible to crash in dsa_loop_exit() because of
an attempt to unregister an invalid PHY. We actually want to the driver probing
in dsa_loop_init() even though fixed_phy_register() may return an error to
exercise how DSA deals with such cases, but we should not be crashing during
driver removal.

Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Florian Fainelli and committed by
David S. Miller
6d9c153a 443cb3a3

+1 -1
+1 -1
drivers/net/dsa/dsa_loop.c
··· 390 390 391 391 mdio_driver_unregister(&dsa_loop_drv); 392 392 for (i = 0; i < NUM_FIXED_PHYS; i++) 393 - if (phydevs[i]) 393 + if (!IS_ERR(phydevs[i])) 394 394 fixed_phy_unregister(phydevs[i]); 395 395 } 396 396 module_exit(dsa_loop_exit);