Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

reset: ti-sci: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Nishanth Menon <nm@ti.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Link: https://lore.kernel.org/r/ab374da386cafd6748aac5bdf66e6be3e1860509.1709674157.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

authored by

Uwe Kleine-König and committed by
Philipp Zabel
6d89df61 7f5aa02a

+2 -4
+2 -4
drivers/reset/reset-ti-sci.c
··· 235 235 return reset_controller_register(&data->rcdev); 236 236 } 237 237 238 - static int ti_sci_reset_remove(struct platform_device *pdev) 238 + static void ti_sci_reset_remove(struct platform_device *pdev) 239 239 { 240 240 struct ti_sci_reset_data *data = platform_get_drvdata(pdev); 241 241 242 242 reset_controller_unregister(&data->rcdev); 243 243 244 244 idr_destroy(&data->idr); 245 - 246 - return 0; 247 245 } 248 246 249 247 static struct platform_driver ti_sci_reset_driver = { 250 248 .probe = ti_sci_reset_probe, 251 - .remove = ti_sci_reset_remove, 249 + .remove_new = ti_sci_reset_remove, 252 250 .driver = { 253 251 .name = "ti-sci-reset", 254 252 .of_match_table = ti_sci_reset_of_match,